597066 - When transitioning to to fullscreen, don't preserve client area content

Status: RESOLVED INVALID

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

Windows preserves the client area when a window changes size. What gets preserved is controlled by the results of wm_nscalcsize. When we transition from normal -> fullscreen, we should not preserve the content of the window and instead just trigger a full repaint. This should smooth over fullscreen transitions quite a bit.

Comment 1

[[not reading bugmail]]

Would this also cover coming back out of fullscreen by either clicking the maximized or fullscreen button to go back to normal mode?

Comment 2

[Jim Mathies [:jimm]]

(In reply to comment #1)
> Would this also cover coming back out of fullscreen by either clicking the
> maximized or fullscreen button to go back to normal mode?

Hmm, not sure, we preserve the content area going back to normal mode, which would be the upper right hand side of the fullscreen window.

Comment 4

[Jim Mathies [:jimm]]

(In reply to comment #2)
> (In reply to comment #1)
> > Would this also cover coming back out of fullscreen by either clicking the
> > maximized or fullscreen button to go back to normal mode?
> 
> Hmm, not sure, we preserve the content area going back to normal mode, which
> would be the upper right hand side of the fullscreen window.

correction - "upper left hand"

Comment 5

[Joe Drew (not getting mail)]

I think we can release with this as it is, but I'd much rather it be fixed than not. :)

Comment 6

[[not reading bugmail]]

I see at least two weirdness issues from bug 604861: 

1) going from normal to maximized or visa versa maximized to normal
2) just adjusting the browser borders in normal browsing mode

The first is shows like paint 3 times.

The second one I notice that the browser paints at least 3 times, like it bounces from the right side, when resizing for ever one movement.  For example, when I resize from left, widen the browser out or move the top border up to make it taller, it paints like it bounces from the right hand side of the browser or from the bottom.  However when resizing from the right or bottom border, or resizing left in and top up, its not real noticeable.

Comment 7

[Jim Mathies [:jimm]]

We use an overlay now, no longer needed.