597215 - Don't do setGrowthIncrement on mobile

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix

We don't have enough space to do this.

Comment 1

[Shawn Wilsher :sdwilsh]

(In reply to comment #0)
> We don't have enough space to do this.
I think it would make more sense to adjust the clients instead of changing the storage code to never follow it though, right?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 476039 [details] [diff] [review]
Fix

minusing based on Shawn's comment.

Also, ifdefing on a GFX define in the middle of storage code without a comment does not seem right.

Comment 3

[Michael Wu [:mwu]]

(In reply to comment #1)
> (In reply to comment #0)
> > We don't have enough space to do this.
> I think it would make more sense to adjust the clients instead of changing the
> storage code to never follow it though, right?

But it's easier to just adjust it here because we care more about minimizing overall space usage than fragmentation on mobile. I would just adjust all the clients to zero anyway.

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> (In reply to comment #1)
> But it's easier to just adjust it here because we care more about minimizing
> overall space usage than fragmentation on mobile. I would just adjust all the
> clients to zero anyway.
Are you sure that's the right thing to do?  As I understand it (taras would know better), fragmentation hurts mobile way more than anything else.

Comment 5

[(dormant account)]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > But it's easier to just adjust it here because we care more about minimizing
> > overall space usage than fragmentation on mobile. I would just adjust all the
> > clients to zero anyway.
> Are you sure that's the right thing to do?  As I understand it (taras would
> know better), fragmentation hurts mobile way more than anything else.

In this case, android is extremely constrained in disk space, so eager preallocation is in conflict. I think it'd be nicer to pref this off, but we cn do that in a followup bug.

Comment 6

[Michael Wu [:mwu]]

Attachment: Android only fix

On Android, the use of a log-structured file system most likely negates any positive effects of setGrowthIncrement.

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 477807 [details] [diff] [review]
Android only fix

>+// Bug 597215: Disk space is extremely limited on Android
Hate comments in the code that force you to go to the bug to see reasoning.  Please elaborate in the comment, but you can still reference the bug number if you want.

r=sdwilsh with that change.

Comment 8

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/edd4b316f5d0