597259 - Add exception... and Get me out of here buttons does not work inside iframe page

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Fernando García Gómez, stripTM]

User-Agent:       Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b6) Gecko/20100101 Firefox/4.0b6
Build Identifier: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b6) Gecko/20100101 Firefox/4.0b6

http://www.seg-social.es/Internet_1/Lanzadera/index.htm?URL=3 contains an iframe https://w6.seg-social.es/BuzonWeb/control?opcion=0&Limpiar=0&URL=3&LANG=1&ESTILO=1 this iframe has a security warning.

In the separate iframe, the buttons "Add exception..." "Get me..." works correctly, but if the page with the warning are inside a iframe, the buttons do not work.

Reproducible: Always

Steps to Reproduce:
1.Enter http://www.seg-social.es/Internet_1/Lanzadera/index.htm?URL=3
2. Click in buttons of warning alert
3.
Actual Results:  
Click do no work

Expected Results:  
Open Add security excepcion dialog

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

confirmed with :
Mozilla/5.0 (X11; Linux i686; rv:2.0b7pre) Gecko/20100921 Firefox/4.0b7pre

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Same bug on windows XP with nightly builds

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

here is the regression window:

Last good nightly: 2010-08-19 First bad nightly: 2010-08-20

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4af78db27055&tochange=c8c886655ea1

Comment 4

[Alice0775 White]

Regression window(cached hourly):
Works:
http://hg.mozilla.org/mozilla-central/rev/e75e9d539c40
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100819180028
Fails:
http://hg.mozilla.org/mozilla-central/rev/80b450a23c6b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100819201833
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e75e9d539c40&tochange=80b450a23c6b

This problem happens after landing thee following changeset.
61fd19a4587f	Jonas Sicking — Bug 546857 Part 3: Make error pages not use xul buttons. r=dao a=blocker

Comment 5

[Alice0775 White]

If I change code as follows then the problem is gone.

     if (aStateFlags & Ci.nsIWebProgressListener.STATE_STOP &&
-        /^about:/.test(aBrowser.contentWindow.document.documentURI)) {
+        /^about:/.test(aWebProgress.DOMWindow.document.documentURI)) {
     aBrowser.addEventListener("click", BrowserOnClick, false);

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Alice, can you attach that as a patch? If so I'll review it and check it in. Thanks for finding this bug!

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Alice, would you like me to take this? I'll take silence as 'yes' this time :)

Comment 8

[Alice0775 White]

Attachment: patch v1

Sorry, to late reply.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in. Thanks for finding the problem and attaching a the patch!!

http://hg.mozilla.org/mozilla-central/rev/b0baa9a75bf2

For future reference, it's great if you can create a proper mercurial patch when attaching a patch for checkin. One that includes username and checkin comment and which applies cleanly. You can create a patch with this info by using |hg export|.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Thanks Fernando :)

Comment 11

[Fernando García Gómez, stripTM]

Pascal no, thanks to everybody.

I can see now that sometimes, when reloading the page it stops working.

Ufff, It seems that the page has been programmed in the 90's.

(1) It is made of some frames, the conflictive one is (2). Which redirects via javascript to (3).

I'm trying to make a min-testcase (4), but I still can't find the problem.

Need Reopened?


(1) http://www.seg-social.es/Internet_1/Lanzadera/index.htm?URL=3
(2) http://www.seg-social.es//Internet_1/Lanzadera/index.htm?frame=aplicacion&URL=3
(3) https://w6.seg-social.es/BuzonWeb/control?opcion=0&Limpiar=0&URL=3&LANG=1&ESTILO=1

(4) http://striptm.com/ejemplos/bugframehttps/

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Please file a separate bug.

And oops, sorry about the misplaced thanks for finding the problem in the first place. Very awesome that you found this before we shipped.