597268 - Quickdraw plugins flicker

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: A fix

roc can explain why this works better than I.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 476110 [details] [diff] [review]
A fix

This looks fine. Let's get it in (plus the patch in bug 596414 this depends on).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Oh, I think you should check mIsPluginView as well as mPluginDrawingModel == NPDrawingModelQuickDraw.

Comment 4

[Josh Aas]

If you do this can you get rid of the Quickdraw paint event code in nsObjectFrame? Specifically, the stuff in "nsPluginInstanceOwner::Paint".

Comment 5

[Josh Aas]

I'd like to review a final version of this before it goes in.

Comment 6

[Joe Drew (not getting mail)]

I only see carbon event model draw code in nsPluginInstanceOwner::Paint.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We can(In reply to comment #4)
> If you do this can you get rid of the Quickdraw paint event code in
> nsObjectFrame? Specifically, the stuff in "nsPluginInstanceOwner::Paint".

We can and should, but we don't have to do it in this patch.

Comment 8

[Joe Drew (not getting mail)]

Attachment: slightly updated fix

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(After the patches here and in bug 596414 land, we can also remove code in layout that handles painting of child widgets.)

Comment 10

[Markus Stange [:mstange]]

So why exactly does this patch fix things? What's the difference between sending the update event directly from drawRect vs from nsObjectFrame.cpp?

Comment 11

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/29e6c5191fa6

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

When we do the update via nsObjectFrame, the plugin paints onto the window while we're drawing the contents of retained layer buffers. After that, the layer manager draws the buffers onto the window, overwriting what the plugin painted.

When we do the update via drawRect on the plugin's view, the plugin paints onto the window after the drawRect for the main NSView, so after the layer manager has drawn layer buffers onto the window.