597321 - Need id for "Move To Group | New Group" sub menu entry in the tab context menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100914 Firefox/4.0b7pre

There is no menu id available for the "Move To Group | New Group" sub menu entry in the tab context menu. It's necessary for our Mozmill tests to access this entry.

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#134

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Comment 2

[Jonathan Watt [:jwatt]]

This patch no longer applies. Please remove the checkin-needed keyword until it's updated to tip and retested on Try, and please use 'hg export' with an appropriate log message (r=, a=) when making patches if you're going to use checkin-needed. See:

http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch for check-in

Simply updated the bitrotted patch to cleanly apply on mc. Did a test-run on tryserver and everything is fine. Do I have to request for a new approval?

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 495387 [details] [diff] [review]
Patch for check-in

No, I don't think so. Approval is for the principle of what you're fixing, not the details of the patch.

Comment 5

[Jonathan Watt [:jwatt]]

Pushed http://hg.mozilla.org/mozilla-central/rev/48a4773a6316

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101212 Firefox/4.0b8pre