Closed Bug 597321 Opened 9 years ago Closed 9 years ago

Need id for "Move To Group | New Group" sub menu entry in the tab context menu

Categories

(Firefox :: Menus, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 4.0b8

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill])

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100914 Firefox/4.0b7pre

There is no menu id available for the "Move To Group | New Group" sub menu entry in the tab context menu. It's necessary for our Mozmill tests to access this entry.

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#134
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #476176 - Flags: review?(dao)
Whiteboard: [mozmill]
Attachment #476176 - Flags: review?(dao) → review+
Attachment #476176 - Flags: approval2.0? → approval2.0+
This patch no longer applies. Please remove the checkin-needed keyword until it's updated to tip and retested on Try, and please use 'hg export' with an appropriate log message (r=, a=) when making patches if you're going to use checkin-needed. See:

http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed
Simply updated the bitrotted patch to cleanly apply on mc. Did a test-run on tryserver and everything is fine. Do I have to request for a new approval?
Attachment #476176 - Attachment is obsolete: true
Attachment #495387 - Flags: review+
Attachment #495387 - Flags: approval2.0?
Comment on attachment 495387 [details] [diff] [review]
Patch for check-in

No, I don't think so. Approval is for the principle of what you're fixing, not the details of the patch.
Attachment #495387 - Flags: approval2.0?
Pushed http://hg.mozilla.org/mozilla-central/rev/48a4773a6316
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101212 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 4.0b8
You need to log in before you can comment on or make changes to this bug.