597389 - If plug-ins disable non-Roman keyboard layout and they don't recover the state, Gecko doesn't recover it

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

1. Load above page with Fx3.6 and Flash Player 10.1.x.x
2. Click a link in the Flash Player which is center of the page (the radio program list)

Then, you cannot use non-Roman keyboard layout on Fx.

Flash Player disables non-Roman keyboard layout and if you click the link, Flash Player doesn't recover the keyboard layout state when it's destroying. Gecko stores latest keyboard layout state when Gecko changes it because 10.4 doesn't provide any APIs for getting the state. And Gecko reduces unnecessary API call at nsTSMManager::SetRomanKeyboardsOnly(). Therefore, Gecko doesn't restore the keyboard state until Gecko's password field gets focus.

# NOTE #1: This bug isn't reproduced on Minefield, probably, the reason is that Minefield uses new APIs which are usable 10.5 and later.
# NOTE #2: This bug isn't reproduced with Flash Player 10.0.x.x. So, this is a regression of Flash Player.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This bug can be reproduced on Fx3.5 too. However, it's going to be dropped but SeaMonkey is going to continue to use 1.9.1 for a while. So, we should fix this bug on 1.9.1 too.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I can't reproduce this bug (testing in FF 3.6.9 on OS X 10.5.8) ... or
at least I don't think I can.

Here's what I did:

1) Load this bug's URL (http://www.tbs.co.jp/radio/todays954/) and
   click somewhere in the Flash object.

   Notice that it's no longer possible to choose Kotoeri Hiragana or
   Katakana from the "flags" menu (those choices are greyed out).

2) Click elsewhere in the page.

   Now it's once again possible to choose Hiragana or Katakana.

3) Click on the Flash object -- Hiragana and Katakana are greyed out.

4) Switch tabs -- Hiragana and Katakana are no longer greyed out.

5) Switch back to the tab with http://www.tbs.co.jp/radio/todays954/
   in it -- Hiragana and Katakana are still not	greyed out.

6) Click on the Flash object -- Hiragana and Katakana are greyed out.

7) Close the current tab (with http://www.tbs.co.jp/radio/todays954/
   in it) -- Hiragana and Katakana are no longer greyed out.

Later I'll try it on OS X 10.6.4.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

(Following up comment #3)

I get the same results on OS X 10.6.4.

By the way, on both OS versions I tested with en-US Firefox and the preferred language was set to English.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Click a link in the Flash Object. Then, you'll open a page on current tab. Then, the keyboard layout limitation isn't canceled.

I can reproduced this bug on 10.5 and 10.6. The original reporter in Japan said that he/she can reproduce this bug on 10.4 too.

Comment 5

[Daniel Veditz [:dveditz]]

CC'ing Charles because it appears it might also be a Flash regression

Comment 6

[Steven Michaud [:smichaud] (Retired)]

> Click a link in the Flash Object. Then, you'll open a page on
> current tab.  Then, the keyboard layout limitation isn't canceled.

OK, thanks.  Now I can reproduce it.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 476234 [details] [diff] [review]
Patch v1.0

This looks fine to me.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 476234 [details] [diff] [review]
Patch v1.0

Thank you, Steven.

This patch just removes an optimizing code for reducing API call. I think that this change doesn't affect to performance.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

NOTE: the method is called at focus moving only when IME state is changed by new focused content.

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 476234 [details] [diff] [review]
Patch v1.0

Approved for 1.9.2.11 and 1.9.1.14, a=dveditz for release-drivers

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c0c261de23ec
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e532600954d0

Comment 12

[Al Billings [:abillings - ex-MoCo]]

Verified fixed in 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.11pre) Gecko/20100923 Namoroka/3.6.11pre. Verified fixed in 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.14pre) Gecko/20100923 Shiretoko/3.5.14pre.