597432 - selecting -u mochitest-o gets all unittests in trychooser

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

gavin brought this to my attention in #build:
his push:  http://hg.mozilla.org/try/rev/659e07e5340b
another push that also got all tests: http://hg.mozilla.org/try/rev/a5d82b7b2d27

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

I am looking at this code, and I only see one scheduler for all the unit test suits.  I am not sure about the inner workings of the BuilderChooserScheduler, but I am going to guess that because mochitest-o was valid for that scheduler, it triggered builds on its builders.  This scheduler has all unit test builders for that platform and test type (opt/debug).

Should we create a scheduler per unit test suite or should unittests be a boolean option to the try chooser?

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to comment #1)
> I am looking at this code, and I only see one scheduler for all the unit test
> suits.  I am not sure about the inner workings of the BuilderChooserScheduler,
> but I am going to guess that because mochitest-o was valid for that scheduler,
> it triggered builds on its builders.  This scheduler has all unit test builders
> for that platform and test type (opt/debug).
> 
> Should we create a scheduler per unit test suite or should unittests be a
> boolean option to the try chooser?

I was wrong.  Ignore comment 1

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: return misc_scheduler json url to try repo, not lsblakk repo

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 476298 [details] [diff] [review]
return misc_scheduler json url to try repo, not lsblakk repo

http://hg.mozilla.org/build/buildbotcustom/rev/b330e31c8a45