597496 - cfx treats files in packages/ as package directories

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

cfx treats files in the packages/ directory as package directories, then falls over because it can't find a package.json file inside them.  But there are good reasons to have files in that directory.  In particular, to configure projects and other settings for text editors and IDEs (i.e. SCiTE.properties and project.komodoedit files).  So cfx should ignore those files.

Atul: you know the most about the way cfx walks the directory structure; is this one of those bugs it would be easy for you to knock off with a small, well-contained patch?

Comment 1

[David Chan [:dchan]]

Attachment: patch.diff

This works on my install, though not sure if it is the best way to fix.

Comment 2

[David Chan [:dchan]]

Attachment: patch.diff

Actually thinking about it more, it is probably better to check that the target is a dir rather than not a file

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 476355 [details] [diff] [review]
patch.diff

Awesome, thanks for the patch David!  Atul: can you review?

Comment 4

[Atul Varma [:atul]]

Comment on attachment 476355 [details] [diff] [review]
patch.diff

Looks great! In the future, it'd be nice if you could wrap the the line to around 78 characters wide, but it's not that big a deal. Thanks for the patch!

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 6

[Brian Warner [:warner :bwarner]]

an equivalent of this patch was present in 1.0b5 .. not sure from what, but it means this can be closed.

Comment 7

[Ed Morley [:emorley]]

Removing checkin-needed due to comment 6.