Closed Bug 597579 Opened 9 years ago Closed 9 years ago

Investigate downloading updates to sd card

Categories

(Toolkit :: Application Update, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
fennec 2.0b3+ ---

People

(Reporter: blassey, Assigned: alexp)

Details

Attachments

(2 files)

We currently download updates to phone memory, which we know gets tight for some users. Putting it on the sd card may be better.
This can be implemented in a similar fashion as the updates dir (e.g. "UpdRootD") which is in the user's profile on Windows.
http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#270

The app update work after that is implemented would be pretty simple.
Fennec even has a directory provider component where we can add the logic to move the "UpdRootD" location
I hit out of space a lot when upgrading, for what it's worth.
Attached patch FixSplinter Review
- Use UpdRootD for Android
- Look for the update APK under /sdcard/downloads
Assignee: nobody → alexp
Status: NEW → ASSIGNED
Attachment #487210 - Flags: review?
Attachment #487210 - Flags: review?(robert.bugzilla)
Attachment #487210 - Flags: review?(blassey.bugs)
Attachment #487210 - Flags: review?
Attached patch Fix (mobile)Splinter Review
Added UpdRootD to DirectoryProvider component.
Attachment #487211 - Flags: review?(mark.finkle)
Make this one blocking 2.0b3?
Status: ASSIGNED → NEW
Attachment #487210 - Flags: review?(blassey.bugs) → review+
I wonder if we should make sure the updates folder is only writable by org.mozilla.fennec
(In reply to comment #7)
> I wonder if we should make sure the updates folder is only writable by
> org.mozilla.fennec

While we're using APK I don't think it's too dangerous to have it accessible by other apps, as the package is signed.

Besides, it seems like we cannot change the file (or dir?) permissions on the SD card. The code, which changed APK permissions, added in the original implementation, fails when tries to change permissions of the file, which is now on the SD card.
Attachment #487211 - Flags: review?(mark.finkle) → review+
Comment on attachment 487210 [details] [diff] [review]
Fix

btw: the dir provider for xpcshell tests force UpdRootD to be the application directory for the tests.
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/unit/head_update.js.in#370
Attachment #487210 - Flags: review?(robert.bugzilla) → review+
Should probably be blocking as it should improve the situation with another blocking bug 598649 (not enough memory for the update download).
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
tracking-fennec: ? → 2.0b3+
Keywords: checkin-needed
pushed http://hg.mozilla.org/mozilla-central/rev/2ee5b0622489 and http://hg.mozilla.org/mobile-browser/rev/54d36adb1d5c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.