597579 - Investigate downloading updates to sd card

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

We currently download updates to phone memory, which we know gets tight for some users. Putting it on the sd card may be better.

Comment 1

[Robert Strong (they/them - no direct email)]

This can be implemented in a similar fashion as the updates dir (e.g. "UpdRootD") which is in the user's profile on Windows.
http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#270

The app update work after that is implemented would be pretty simple.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Fennec even has a directory provider component where we can add the logic to move the "UpdRootD" location

Comment 3

[[e-mail] (:bhearsum)]

I hit out of space a lot when upgrading, for what it's worth.

Comment 4

[Alex Pakhotin (:alexp)]

Attachment: Fix

- Use UpdRootD for Android
- Look for the update APK under /sdcard/downloads

Comment 5

[Alex Pakhotin (:alexp)]

Attachment: Fix (mobile)

Added UpdRootD to DirectoryProvider component.

Comment 6

[Alex Pakhotin (:alexp)]

Make this one blocking 2.0b3?

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

I wonder if we should make sure the updates folder is only writable by org.mozilla.fennec

Comment 8

[Alex Pakhotin (:alexp)]

(In reply to comment #7)
> I wonder if we should make sure the updates folder is only writable by
> org.mozilla.fennec

While we're using APK I don't think it's too dangerous to have it accessible by other apps, as the package is signed.

Besides, it seems like we cannot change the file (or dir?) permissions on the SD card. The code, which changed APK permissions, added in the original implementation, fails when tries to change permissions of the file, which is now on the SD card.

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 487210 [details] [diff] [review]
Fix

btw: the dir provider for xpcshell tests force UpdRootD to be the application directory for the tests.
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/unit/head_update.js.in#370

Comment 10

[Alex Pakhotin (:alexp)]

Should probably be blocking as it should improve the situation with another blocking bug 598649 (not enough memory for the update download).

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/2ee5b0622489 and http://hg.mozilla.org/mobile-browser/rev/54d36adb1d5c