597608 - Some files do not get updated when a new APK is installed over the old one

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

After automatic update from 2010-09-16 nightly to 2010-09-17 Fennec suggests to get and install another update though it is not available yet for the 2010-09-17 build.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

This happens because the application.ini does not get updated. On the first run of Fennec this and some other files get extracted from the .apk and get the current LastModified time. When a new version starts it checks for the extracted files and finds their timestamp time is later than the one in the archive, so those files are skipped.

The fix is to set the LastModified time for the extracted files to the one from the archive entry, so the timestamp check would work properly.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 476450 [details] [diff] [review]
Fix

Looks fine

Comment 3

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/3afed01ce2d1

Comment 4

[Cristian Nicolae (:xti)]

Updates are working fine on the latest Nightly build. Due to this fact and because this bug is old now, I will close this issue as verified fixed.

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110913
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2