Closed Bug 597664 Opened 9 years ago Closed 9 years ago

Add finalURI.spec for the mar file download to the local update xml and log the finalURI.spec along with the original URI.spec

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b7
Tracking Status
status1.9.2 --- wanted
status1.9.1 --- wanted

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(1 file, 1 obsolete file)

This will assist in troubleshooting problems with the mirror servers
Attached patch patch rev1 (obsolete) — Splinter Review
I don't think it is worth the time to add tests for this since finalURL is only for troubleshooting.
Attachment #476579 - Flags: review?(dtownsend)
Henrik, just an fyi that this will add the actual url used to download the mar to the active-update.xml and updates.xml
Attached patch patch rev2Splinter Review
Actually, this doesn't need to protect against the finalURL attribute not being present
Attachment #476579 - Attachment is obsolete: true
Attachment #476581 - Flags: review?(dtownsend)
Attachment #476579 - Flags: review?(dtownsend)
(In reply to comment #2)
> Henrik, just an fyi that this will add the actual url used to download the mar
> to the active-update.xml and updates.xml

Is this URL the load balancer or the real mirror server we are downloading the update from?
Status: NEW → ASSIGNED
It is the real one.
Attachment #476581 - Flags: review?(dtownsend) → review+
Attachment #476581 - Flags: approval2.0? → approval2.0+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/e4fdb23efa33

I don't think a test is necessary for this but will likely add one as time permits
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Would we be able to backport this change to older branches (1.9.2 and 1.9.1)? That would also give us the information for software update tests not only on trunk.
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101012 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
Robert, do we need a different patch for the older branches or can we request approval?
A new patch and atm I am busy with Firefox 4.0 work so it will have to wait until I have time to backport this and other patches that aren't critical.
This is fairly critical for branch releases as the past 3 have had slow mirrors impact end-to-end release time. It isn't as important as most FF4 blockers though...
The patch in bug 530872 includes this for 1.9.2.
Depends on: 530872
You need to log in before you can comment on or make changes to this bug.