597664 - Add finalURI.spec for the mar file download to the local update xml and log the finalURI.spec along with the original URI.spec

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

This will assist in troubleshooting problems with the mirror servers

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

I don't think it is worth the time to add tests for this since finalURL is only for troubleshooting.

Comment 2

[Robert Strong (they/them - no direct email)]

Henrik, just an fyi that this will add the actual url used to download the mar to the active-update.xml and updates.xml

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Actually, this doesn't need to protect against the finalURL attribute not being present

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> Henrik, just an fyi that this will add the actual url used to download the mar
> to the active-update.xml and updates.xml

Is this URL the load balancer or the real mirror server we are downloading the update from?

Comment 5

[Robert Strong (they/them - no direct email)]

It is the real one.

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/e4fdb23efa33

I don't think a test is necessary for this but will likely add one as time permits

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Would we be able to backport this change to older branches (1.9.2 and 1.9.1)? That would also give us the information for software update tests not only on trunk.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101012 Firefox/4.0b8pre

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Robert, do we need a different patch for the older branches or can we request approval?

Comment 10

[Robert Strong (they/them - no direct email)]

A new patch and atm I am busy with Firefox 4.0 work so it will have to wait until I have time to backport this and other patches that aren't critical.

Comment 11

[LegNeato]

This is fairly critical for branch releases as the past 3 have had slow mirrors impact end-to-end release time. It isn't as important as most FF4 blockers though...

Comment 12

[Robert Strong (they/them - no direct email)]

The patch in bug 530872 includes this for 1.9.2.