--disable-rdf breaks the build

RESOLVED FIXED in mozilla10

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: mounir, Assigned: Matheus Kerschbaum)

Tracking

({dev-doc-complete})

Trunk
mozilla10
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

23.98 KB, patch
Matheus Kerschbaum
: review+
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
On current trunk, we can't build with --disable-rdf
Moving to build-config, we may as well remove that build option.
Component: RDF → Build Config
QA Contact: rdf → build-config
Can we just remove RDF? :) (But yeah, removing the option sounds fine.)
XUL still relies on having localstore.rdf for persisting various things, although I'm starting to kill it off in bug 559505. Makes sense to just remove this --footgun until such time as the platform isn't actually needing it.
(Assignee)

Updated

6 years ago
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
Flags: in-testsuite-
(Assignee)

Updated

6 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 4

6 years ago
Created attachment 571483 [details] [diff] [review]
patch
Attachment #571483 - Flags: review?(ted.mielczarek)
Comment on attachment 571483 [details] [diff] [review]
patch

Review of attachment 571483 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/library/Makefile.in
@@ +106,1 @@
>  	$(NULL)

Can you change the indent of all three of these blocks while you're here? (To two-space instead of tab.)
Attachment #571483 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 572680 [details] [diff] [review]
patch for checkin
Attachment #571483 - Attachment is obsolete: true
Attachment #572680 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 7

6 years ago
https://tbpl.mozilla.org/?tree=Try&rev=1e7c86487f42 :-)

Comment 8

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f0be211721f

(Leaving milestone blank for now, since not sure if it will make today's aurora uplift)

Updated

6 years ago
Keywords: checkin-needed

Comment 9

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1f0be211721f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
This option was never documented, but its removal is listed on Firefox 10 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.