597832 - Compile nsUTF8ToUnicode.cpp with SSE2 options for Solaris Studio compiler

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ginn Chen]

Solaris Studio compiler requires -xarch=sse2 and optimize option to compile SSE2 intrinsics.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 476624 [details] [diff] [review]
patch

Is there any reason you can't just set this flag globally, or at least for everything in this Makefile?

Comment 3

[Ginn Chen]

For Solaris Studio, there're some limitations.

Using -xarch=sse2 will optimize mmx, sse intrinsics to sse2 assembly. It will break the cpuid test somewhere.
Also it may generate sse2 assembly randomly, e.g. for builtin memcpy in constructors.

Ideally, we should only use this option for specific functions.
Then we have to spilt nsUTF8ToUnicode.cpp into 2 files.

So far, I didn't see Solaris Studio generates SIMD assembly outside Convert_ascii_run() for this file.
So I think using this option for only this file is an acceptable option.

Comment 4

[(not currently active) Ted Mielczarek]

There's no way to do this via pragma, is there? I just hate adding extra platform-specific crap to Makefiles like this.

Comment 5

[Ginn Chen]

(In reply to comment #4)
> There's no way to do this via pragma, is there? I just hate adding extra
> platform-specific crap to Makefiles like this.

No, there's no pragma to do it for Solaris Studio.

I hate it, too.

Comment 6

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/4b5e489173b6