[OpenGL] ASSERTION: Expected integer device offsets in gfxXlibNativeRenderer.cpp, line 223

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
Graphics
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

unspecified
mozilla2.0b8
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 476690 [details] [diff] [review]
Use signed comparison instead

Currently we convert the offsets into unsigned integers and compare, with accelerated layers we are sometimes getting negative value device offsets.

Is there any reason for the unsigned check that I'm missing?
Attachment #476690 - Flags: review?(karlt)
Comment on attachment 476690 [details] [diff] [review]
Use signed comparison instead

(In reply to comment #0)
> Is there any reason for the unsigned check that I'm missing?

No reason.  It was a bad test.
Attachment #476690 - Flags: review?(karlt) → review+
Comment on attachment 476690 [details] [diff] [review]
Use signed comparison instead

Requesting approval2.0 for a safe correction to an assertion.
Attachment #476690 - Flags: approval2.0?
Blocks: 580440
Attachment #476690 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

7 years ago
Blocks: 602200
http://hg.mozilla.org/mozilla-central/rev/a4acedb0dc7e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8

Updated

7 years ago
Assignee: nobody → matt.woodrow+bugzilla
You need to log in before you can comment on or make changes to this bug.