Closed
Bug 597915
Opened 14 years ago
Closed 14 years ago
[OpenGL] ASSERTION: Expected integer device offsets in gfxXlibNativeRenderer.cpp, line 223
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
karlt
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
Currently we convert the offsets into unsigned integers and compare, with accelerated layers we are sometimes getting negative value device offsets.
Is there any reason for the unsigned check that I'm missing?
Attachment #476690 -
Flags: review?(karlt)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 476690 [details] [diff] [review]
Use signed comparison instead
(In reply to comment #0)
> Is there any reason for the unsigned check that I'm missing?
No reason. It was a bad test.
Attachment #476690 -
Flags: review?(karlt) → review+
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 476690 [details] [diff] [review]
Use signed comparison instead
Requesting approval2.0 for a safe correction to an assertion.
Attachment #476690 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #476690 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•13 years ago
|
Assignee: nobody → matt.woodrow+bugzilla
You need to log in
before you can comment on or make changes to this bug.
Description
•