597937 - 4.0b6 fails to compile ipc/glue/GeckoChildProcessHost.cpp due to changed LaunchApp API

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jeremy Huddleston]

I'm trying to build the 4.0b6 tarball for darwin/X11, but it's failing to build GeckoChildProcessHost.cpp due to changed API ... interestingly, I don't see the ipc directory in mozilla-central, so I'm not sure if this is still relevant or if this come from somwhere other than http://hg.mozilla.org/mozilla-central

/usr/bin/g++-4.0 -o GeckoChildProcessHost.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include ../../config/gcc_hidden.h -DMOZ_CHILD_PROCESS_NAME=\"plugin-container\" -DMOZ_CHILD_PROCESS_BUNDLE=\"plugin-container.app/Contents/MacOS/\" -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DOSTYPE=\"Darwin9.8.0\" -DOSARCH=Darwin -DEXCLUDE_SKIA_DEPENDENCIES -DCHROMIUM_MOZILLA_BUILD  -DOS_MACOSX=1 -DOS_POSIX=1  -I../../toolkit/crashreporter -I../../ipc/chromium/src -I../../ipc/glue -I../../ipc/ipdl/_ipdlheaders  -I. -I. -I../../dist/include -I../../dist/include/nsprpub  -I/opt/local/include/nspr -I/opt/local/include/nss -I/opt/local/include  -I/opt/local/include    -fPIC -I/opt/local/include -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -pipe -O0 -ggdb3 -arch ppc -fno-strict-aliasing -fpascal-strings -fno-common -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2  -I/opt/local/include -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/GeckoChildProcessHost.pp GeckoChildProcessHost.cpp
GeckoChildProcessHost.cpp: In member function ‘bool mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunch(std::vector<std::string, std::allocator<std::string> >)’:
GeckoChildProcessHost.cpp:344: error: no matching function for call to ‘LaunchApp(std::vector<std::string, std::allocator<std::string> >&, base::file_handle_mapping_vector&, base::environment_map&, bool, base::ProcessHandle*)’
../../ipc/chromium/src/base/process_util.h:139: note: candidates are: bool base::LaunchApp(const std::vector<std::string, std::allocator<std::string> >&, const base::file_handle_mapping_vector&, bool, base::ProcessHandle*, task_t*)
../../ipc/chromium/src/base/process_util.h:147: note:                 bool base::LaunchApp(const std::vector<std::string, std::allocator<std::string> >&, const base::file_handle_mapping_vector&, const base::environment_map&, bool, base::ProcessHandle*, task_t*)
../../ipc/chromium/src/base/process_util.h:168: note:                 bool base::LaunchApp(const CommandLine&, bool, bool, base::ProcessHandle*)
GeckoChildProcessHost.cpp:277: warning: ignoring return value of ‘FilePath FilePath::AppendASCII(const std::string&) const’, declared with attribute warn_unused_result
GeckoChildProcessHost.cpp:280: warning: ignoring return value of ‘FilePath FilePath::AppendASCII(const std::string&) const’, declared with attribute warn_unused_result
make[4]: *** [GeckoChildProcessHost.o] Error 1
make[3]: *** [libs] Error 2
make[2]: *** [libs_tier_platform] Error 2
make[1]: *** [tier_platform] Error 2
make: *** [default] Error 2

Comment 1

[Jeremy Huddleston]

This seems addressed in 4.0b7