Closed Bug 597995 Opened 14 years ago Closed 14 years ago

Tags of bookmarks is lost doing UNDO after a CUT or DELETE

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b10
Tracking Flags:
Tracking Status
status1.9.2 --- ?

People

(Reporter: accmaia, Assigned: mak)

References

Details

(Keywords: dataloss, regression, Whiteboard: [fixed-in-places])

Attachments

(1 file)

patch v1.0
4.04 KB, patch
dietrich
: review+
dietrich
: approval2.0+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10 GTB7.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10 GTB7.1

After a "cut" (Ctrl+X) of bookmark entry followed by an "undo" (Ctrl+Z), its tag disappears.

Reproducible: Always

Steps to Reproduce:
1. Mark a bookmark with a tag
2. Ctrl+X (cut)
3. Ctrl+Z (undo)
4. You the bookmark back, but without the original tag
Actual Results:  
I got the bookmark back, but without the original tag

Expected Results:  
The natural result would be to get the same entry, with the original tag
Version: unspecified → 3.6 Branch
confirmed, it's pretty weird.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: dataloss
Blocks: 560198
Attached patch patch v1.0 — — Splinter Review 
Looks like we lose tags also for the simple "delete a bookmark and undo" case and it's a FX4 regression.
The patch was not that hard or time consuming.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #503574 - Flags: review?(dietrich)
Keywords: regression
Summary: Tags of bookmarks disappear after "cut" (CTRL+X) + "undo" (Ctrl+Z) → Tags of bookmarks is lost doing UNDO after a CUT or DELETE
Flags: in-testsuite?
Attachment #503574 - Flags: review?(dietrich)
Attachment #503574 - Flags: review+
Attachment #503574 - Flags: approval2.0+
http://hg.mozilla.org/projects/places/rev/c3bec086d8f8
Flags: in-testsuite? → in-testsuite+
Whiteboard: [fixed-in-places]
http://hg.mozilla.org/mozilla-central/rev/c3bec086d8f8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
Blocks: 627416
No longer blocks: FF2SM
status1.9.2: --- → ?
Version: 3.6 Branch → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: