Can't call method "isa" without a package or object reference at ./email_in.pl line 377.

RESOLVED FIXED in Bugzilla 3.6

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: LpSolit, Assigned: LpSolit)

Tracking

3.6.2
Bugzilla 3.6
Bug Flags:
approval +
approval4.0 +
approval3.6 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 476913 [details] [diff] [review]
patch, v1

If $msg is not an object, 'Can't call method "isa" without a package or object reference' is thrown instead of the expected error message. This happens if you call ThrowUserError() with an error tag defined in your extension (this doesn't happen when the error tag is in user-error.html.tmpl itself).
Attachment #476913 - Flags: review?(mkanat)

Comment 1

8 years ago
Comment on attachment 476913 [details] [diff] [review]
patch, v1

Mmm, should use "blessed" instead of "ref", because $@ could be an unblessed reference, which would also fail.
Attachment #476913 - Flags: review?(mkanat) → review-

Updated

8 years ago
Target Milestone: --- → Bugzilla 3.6
(Assignee)

Comment 2

8 years ago
Created attachment 477301 [details] [diff] [review]
patch, v2
Assignee: incoming.email → LpSolit
Attachment #476913 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #477301 - Flags: review?(mkanat)

Comment 3

8 years ago
Comment on attachment 477301 [details] [diff] [review]
patch, v2

I think that makes the line longer than 80 characters, though, so just add a newline on checkin.
Attachment #477301 - Flags: review?(mkanat) → review+

Updated

8 years ago
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
(Assignee)

Comment 4

8 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified email_in.pl
Committed revision 7486.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified email_in.pl
Committed revision 7415.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified email_in.pl
Committed revision 7180.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.