Open Bug 598188 Opened 10 years ago Updated 9 years ago
Don't allow Object
Frame create and drop layer surface inside one transaction
Recently we had bug 596769, where remote layers were not expecting Layer create/destroy inside paint transaction We fixed that problem on remote layers side, but did not fix problem in ObjectFrame
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #476949 - Flags: review?(roc)
Why is this correct? I don't think this is needed.
Because we always call CreateImageLayer when plugin is just created (layer not available in aManager)... and then we immediately destroying that layer, because SetImageContainer return FALSE (GetSurface return NULL)
I see. Why not moving all the layer-getting down below the call to SetCurrentImage?
Attachment #477058 - Flags: review?(roc) → review+
This will make Shadow Layer manager life easier, also prevent some unexpected behavior
blocking2.0: --- → ?
oleg - could you provide a risk/reward statement? Why do we need this now? what could break if we didn't take it?
Minusing until we get more information.
blocking2.0: ? → -
You need to log in before you can comment on or make changes to this bug.