Open
Bug 598188
Opened 15 years ago
Updated 3 years ago
Don't allow ObjectFrame create and drop layer surface inside one transaction
Categories
(Core :: Layout, defect)
Tracking
()
NEW
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: romaxa, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.19 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Recently we had bug 596769, where remote layers were not expecting Layer create/destroy inside paint transaction
We fixed that problem on remote layers side, but did not fix problem in ObjectFrame
|
Reporter | |
Comment 1•15 years ago
|
||
Why is this correct? I don't think this is needed.
|
|
Reporter | |
Comment 3•15 years ago
|
||
Because we always call CreateImageLayer when plugin is just created (layer not available in aManager)... and then we immediately destroying that layer, because SetImageContainer return FALSE (GetSurface return NULL)
I see. Why not moving all the layer-getting down below the call to SetCurrentImage?
|
|
Reporter | |
Comment 5•15 years ago
|
||
Attachment #476949 -
Attachment is obsolete: true
Attachment #477058 -
Flags: review?(roc)
Attachment #476949 -
Flags: review?(roc)
Attachment #477058 -
Flags: review?(roc) → review+
|
|
Reporter | |
Comment 6•15 years ago
|
||
This will make Shadow Layer manager life easier, also prevent some unexpected behavior
blocking2.0: --- → ?
|
||
Comment 7•15 years ago
|
||
oleg - could you provide a risk/reward statement? Why do we need this now? what could break if we didn't take it?
Minusing until we get more information.
blocking2.0: ? → -
|
||
Comment 9•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: romaxa → nobody
Status: ASSIGNED → NEW
|
||
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•