598208 - Make sure SMIL reftests for mixed px & percent values pass after bug 594933 is fixed (e.g. anim-css-strokewidth-1-by-pct-px.svg)

Status: NEW

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

layout/reftests/svg/smil/style/reftest.list says:

> # 'stroke-width' property, from/by/to with percent values
> # XXXdholbert the mixed pct + px tests fail right now, because nsStyleAnimation
> # doesn't support combining pct-values with coord-values yet (Bug 520234)
> == anim-css-strokewidth-1-by-pct-pct.svg      anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-by-pct-px.svg       anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-by-px-pct.svg       anim-css-strokewidth-1-ref.svg
> == anim-css-strokewidth-1-from-by-pct-pct.svg anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-from-by-pct-px.svg  anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-from-by-px-pct.svg  anim-css-strokewidth-1-ref.svg
> == anim-css-strokewidth-1-from-to-pct-pct.svg anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-from-to-pct-px.svg  anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-from-to-px-pct.svg  anim-css-strokewidth-1-ref.svg
> == anim-css-strokewidth-1-to-pct-pct.svg      anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-to-pct-px.svg       anim-css-strokewidth-1-ref.svg
> fails == anim-css-strokewidth-1-to-px-pct.svg       anim-css-strokewidth-1-ref.svg

This section of the file is unchanged since late 2009. Bug 520234 is fixed now, but presumably these tests still fail, since Tinderbox isn't permaorange. What's going on?

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> This section of the file is unchanged since late 2009. Bug 520234 is fixed now,

As of last week, yes.

> but presumably these tests still fail, since Tinderbox isn't permaorange.

I'll take a look -- it may be the SMIL code needs updating to recognize that nsStyleAnimation supports mixing px & pct values now.

Comment 2

[Daniel Holbert [:dholbert]]

Ah, these tests still fail because:
 - Bug 520234 supports interpolating between px & pct values using calc()
 - calc() doesn't work for stroke-width or other SVG-specific properties yet (that's bug 594933)
 - The SMIL reftests mentioned in comment 0 use stroke-width.

So, the tests will still fail until bug 594933 is fixed.  I'm reshaping this bug into making sure the tests pass once that bug is fixed.  (Hopefully, that should Just Work.)

In the meantime, the XXX comment in reftest.list needs updating to mention bug 594933.

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to comment #2)
> In the meantime, the XXX comment in reftest.list needs updating to mention bug
> 594933.

I'll take care of this in a reftest.list comment-only push, which I think can bypass the "b7-blockers-only" tree-restriction. (I'll push within 3 minutes of a "real" commit, so as not to generate a useless tinderbox cycle.)

Comment 4

[Robert Longson [:longsonr]]

Daniel, if you're just changing reftest fixes would you mind including the patch in bug 580983 please?

Comment 5

[Daniel Holbert [:dholbert]]

Ah, sorry -- I didn't see comment 4 until it was too late.  I can land that later, though.

Pushed comment 3 (including a removal of an obsolete comment about colors in that reftest.list file):
http://hg.mozilla.org/mozilla-central/rev/c0ee5c1fd6f5

Comment 6

[Colleen Regan]

Attachment: same problem

Thanks from grealobecdan1981.