598231 - Make number of prompts before "Prevent this page from creating additional dialogs" a tunable pref

Status: REOPENED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Biju]

We need Javascript to be turned on to show alert/confirm/prompt by a webpage.

All modern day browsers there are better way to get user input/action than using alert/confirm/prompt.

Only use for alert/confirm/prompt is to do some quick debugging stuff.

So it is OK to show 
   [ ] Prevent this page from creating additional dialogs.
On every alert/confirm/prompt


patch for bug 61098 (attachment 476153 [details] [diff] [review])
has 
* dialogDuration
* dom.successive_dialog_time_limit
* SUCCESSIVE_DIALOG_TIME_LIMIT
* topWindow->mDialogAbuseCount
* MAX_DIALOG_COUNT
* topWindow->mLastDialogQuitTime

We could remove all those...
That way we actually reduce some code...

Comment 1

[Johnny Stenback (:jst)]

Not blocking, and while I agree that pages have better ways to get user input/action, the fact is that modal dialogs *are* used on the web, and IMO this is WONTFIX.

Comment 2

[Biju]

Actually I wanted to get rid-off alert/prompt/confirm
It is really a nuisance, 
I dislike modal screen also in the desktop applications...

And as I know...

(In reply to comment #1)
> the fact is that modal dialogs *are* used on the web

I am OK with just being it deprecated by W3C/WHATWG

We really need to discourage developers using it.
A better simple way to achieve is to show 
   [ ] Prevent this page from creating additional dialogs.
in every dialog.

As our fix at bug 61098 will again allow alert/confirm/prompt on next visit.
it is OK if user accidentally check.

Additionally we could get rid-off 
1. one about:config item dom.successive_dialog_time_limit
2. A lot of unnecessary code.
3. Also help user who want it at a lesser count than 12
   bug 61098 Comment 318

Comment 3

[Daniel Veditz [:dveditz]]

I have to agree with bug 61098 comment 318 that 12 is too high a count. In the case of a true "eviltrap" site by time you see the checkbox you're no longer thankful for the way out, you're annoyed AT FIREFOX for having a solution and holding out on you.

Instead of hardcoding the number it should be a (hidden) pref, and we should lower the default value to 3 or no more than 5.

As a pref addons could customize the browser to different values (even if we left the default set to the current value), and Biju could get what he wants in this bug (and what I'd like) by setting it to 0.

Reopening bug with the above counter-proposal to your WONTFIX, and also because I disagree with your reasoning: Having the checkbox appear consistently on prompt service dialogs does not remove them from the web, it just means users have a consistent experience when they are used and a way out when they are ABused.

Comment 4

[Daniel Veditz [:dveditz]]

I guess bug 598536 was filed after this to lower the number, make this one about converting to a pref then.

Comment 5

[Firefox Bug Husbandry Bot]

Bulk priority change, per :mdaly