Closed
Bug 598236
Opened 14 years ago
Closed 14 years ago
nsHTMLInputElement should not ask nsFileControlFrame to know the filters for the file picker
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.88 KB,
patch
|
smaug
:
review+
sicking
:
approval2.0+
|
Details | Diff | Splinter Review |
Before, the frame was creating the file picker. When the file picker creation has been moved to the content, this method hasn't been moved.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #477002 -
Flags: review?(Olli.Pettay)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Hmmm, some tests were expecting appendFilters to be called... and I wrote that :( I wonder why we need AppendFilters(filterAll) to be called. Shouldn't we expect the file picker to revert to that value otherwise? GTK file picker looks nicer without adding this filter (it removes a useless button)...
Attachment #477002 -
Attachment is obsolete: true
Attachment #477019 -
Flags: review?(Olli.Pettay)
Attachment #477002 -
Flags: review?(Olli.Pettay)
|
||
Updated•14 years ago
|
Attachment #477019 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #477019 -
Flags: approval2.0?
Attachment #477019 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/c37c14cd682c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•