Closed Bug 598236 Opened 9 years ago Closed 9 years ago

nsHTMLInputElement should not ask nsFileControlFrame to know the filters for the file picker

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 1 obsolete file)

Before, the frame was creating the file picker. When the file picker creation has been moved to the content, this method hasn't been moved.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #477002 - Flags: review?(Olli.Pettay)
Blocks: 590386
Attached patch Patch v1.1Splinter Review
Hmmm, some tests were expecting appendFilters to be called... and I wrote that :(
I wonder why we need AppendFilters(filterAll) to be called. Shouldn't we expect the file picker to revert to that value otherwise? GTK file picker looks nicer without adding this filter (it removes a useless button)...
Attachment #477002 - Attachment is obsolete: true
Attachment #477019 - Flags: review?(Olli.Pettay)
Attachment #477002 - Flags: review?(Olli.Pettay)
Attachment #477019 - Flags: review?(Olli.Pettay) → review+
Attachment #477019 - Flags: approval2.0?
Pushed:
http://hg.mozilla.org/mozilla-central/rev/c37c14cd682c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.