nsHTMLInputElement should not ask nsFileControlFrame to know the filters for the file picker

RESOLVED FIXED in mozilla2.0b7

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla2.0b7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Before, the frame was creating the file picker. When the file picker creation has been moved to the content, this method hasn't been moved.
(Assignee)

Comment 1

8 years ago
Created attachment 477002 [details] [diff] [review]
Patch v1
Attachment #477002 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

8 years ago
Blocks: 590386
(Assignee)

Comment 2

8 years ago
Created attachment 477019 [details] [diff] [review]
Patch v1.1

Hmmm, some tests were expecting appendFilters to be called... and I wrote that :(
I wonder why we need AppendFilters(filterAll) to be called. Shouldn't we expect the file picker to revert to that value otherwise? GTK file picker looks nicer without adding this filter (it removes a useless button)...
Attachment #477002 - Attachment is obsolete: true
Attachment #477019 - Flags: review?(Olli.Pettay)
Attachment #477002 - Flags: review?(Olli.Pettay)

Updated

8 years ago
Attachment #477019 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

8 years ago
Attachment #477019 - Flags: approval2.0?
(Assignee)

Comment 3

8 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/c37c14cd682c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.