Closed
Bug 598270
Opened 14 years ago
Closed 12 years ago
HUD should keep a reference to its <browser>
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Dolske, Unassigned)
Details
Gavin made a frowny face in bug 596371 comment 11: >diff --git a/toolkit/components/console/hudservice/HUDService.jsm b/toolkit/components/console/hudservice/HUDService.jsm > getContentWindowFromHUDId: function HS_getContentWindowFromHUDId(aHUDId) >+ var node = nodes[i]; >+ >+ if (node.localName == "stack" && >+ node.firstChild && >+ node.firstChild.contentWindow) { >+ return node.firstChild.contentWindow; so ugly :( "hud" objects should really have direct references to their associated <browser>. The whole HUD object hierarchy is horribly confusing though. File a followup?
Comment 1•14 years ago
|
||
(In reply to comment #0) > Gavin made a frowny face in bug 596371 comment 11: > so ugly :( "hud" objects should really have direct references to their > associated <browser>. The whole HUD object hierarchy is horribly confusing > though. File a followup? indeed it is. We have been gun shy about holding too many references in hopes of not introducing leaks. Please file a followup. We would like to clean and straighten out some of this gunk post fx-4.
Updated•14 years ago
|
Summary: HUD should keep a reference to it's <browser> → HUD should keep a reference to its <browser>
Comment 2•12 years ago
|
||
I am pretty sure this was fixed a very long time ago.
Status: NEW → RESOLVED
Closed: 12 years ago
Component: Developer Tools → Developer Tools: Console
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•