598302 - [shipping] Enable the workflow app for shipping

Status: RESOLVED INCOMPLETE

(Webtools Graveyard :: Elmo, defect, P2)

Description

[Staś Małolepszy :stas]

In order to turn the todo app for shipping, we will need to do some configuration, as documented in http://bitbucket.org/stasm/todo/src/tip/README.rst.

I have a WIP patch that I use for testing. I'll work on it and attach it here.

Comment 1

[Axel Hecht [:Pike]]

Can you attach that WIP patch here for comment?

Comment 2

[Staś Małolepszy :stas]

Attachment: WIP patch 1

Here's a WIP patch I've been testing recently.

* I removed the placeholder text in some places (like 'Pretty chart goes here')

* I changed the navigation in shipping/pushes to make it more consistent with the navigation on the overview and tasks pages.

* I'm not sure about the URL scheme, in particular, the 'overview' URL for combined views [*].

* FIXME: in shipping.views.teamsnippet, select only those appvers that are being worked on for the locale.

* FIXME: in shipping.views.app.project_overview, query only for locales related to the appversion.

* TODO: show signoff status (accepted, pending, etc.) in team-snippet.html and combined_overview.html.



[*] fwiw, here's our notes about the URLs from the wireframes discussion:

default url scheme:
/shipping/overview/fy-NL/fx4.0 (locale comes first)

how to display nl and fy-NL together?
* hidden feature: pass a couple of 'locale' query args and the template will show each section for each locale
like this: /shipping/overview?project=fx4.0&locale=fy-NL&locale=nl (since the locale comes first in the url, you need to explicitly pass all as query args if you want 1 project and multiple locales)
how to display two projects together?
* same thing:  /shipping/overview?locale=fy-NL&project=fx4.0&project=tb3.1
* or: /shipping/overview/fy-NL&project=fx4.0&project=tb3.1 (there's only one locale, so you can put in right after the slash instead of making it a query arg

Comment 3

[Staś Małolepszy :stas]

Attachment: WIP patch 2

changes from the previous patch:

- added titles on all new pages
- show locales related to an appver on project overview page
- show appvers related to locales in the team snippet
- show friendly messages if there's no tasks/trackers to display
- add a context variable to force reload after logging in

There still are two TODOs in this patch, mentioned before: "show signoff status (accepted, pending, etc.) in team-snippet.html and combined_overview.html." It would be cool to have this, but it seems that it's outside of the scope f this bug to implement this. I'd prefer to file a follow up bug once this lands.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 498974 [details] [diff] [review]
WIP patch 2

There are a few things here:

Nit, "Project Localizations" sounds like jargon to me, and in a wider reading of the term project, it might even be wrong.

I don't think we should use the "combined_" lingo at all. Combining means bringing together, it's more of a union, and what we're doing is an intersection. Use view names that actually describe the view, and not the role it plays in the IA? overview_appversion_for_locale or something is much more descriptive, imho.

I'd rather not use the term "project" in shipping at all, other than at the point where you map TodoProject.

The related name for TodoProject seems odd, you're using the django app name there, I'd rather see the actual AppVersion or so.

All view methods should have doc strings describing what they're doing etc.

I don't think the current patch is on a public instance so that I can see the generated output?