598363 - Context menu cannot be dismissed after opening a link in a new tab.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b7pre)Gecko/20100921 Firefox/4.0b7pre Fennec/2.0b1pre

Mozilla/5.0 (Android; Linux armv71; rv2.0b7pre) Gecko/20100921 Firefox/4.0b7pre Fennec/2.0b1pre

1. go to url: http://people.mozilla.com/~nhirata/
2. long tap on html_tp link
3. select : open in a new tab in the context menu
4. long tap on html_tp link again
5. click outside the context menu

Expected:
Context menu dismisses

Actual:
context menu does not dismiss.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It looks like this has to do with either memory or a page loading at the same time.  It's harder to reproduce now, you need to do step 1 ~ 3 multiple times to have around 8 tabs or so to get this issue to occur.  It still does occur on both.

May need to take a relook after bug 598331 lands.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

litmus test case created : 
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=13540

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Matt - can you repo this?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

in order to reproduce this, I need to have the tab bar hidden and open the context menu while the "New tab opened" alert is visible

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: patch

ContextHelper.hide() is called twice: Once when NewTabPopup.show calls BrowserUI.pushPopup, and once by the context-commands onclick handler.  The second time it's called, its popPopup pops the wrong popup.

This patch fixes this in two ways.  First, it fixes ContextHelper.hide() so it doesn't do anything if the menu is already hidden.

That's enough to fix this bug, but this could easily happen again if some other code calls popPopup() while its popup is no longer pushed.  To prevent this, I also added an argument to popPopup() so it can check that the right popup is popped.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 487076 [details] [diff] [review]
patch

Nice

Comment 7

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/df1c79eb047e

Comment 8

[Matt Brubeck (:mbrubeck)]

Attachment: followup

A bug in the patch is causing an uncaught exception when showing a notification on desktop/Maemo.

Comment 9

[Matt Brubeck (:mbrubeck)]

followup pushed: http://hg.mozilla.org/mobile-browser/rev/8d0f0009361d

Comment 10

[Ayan Shah[:ashah]]

verified fixed on:
Mozilla/5.0(Android; Linux armv7l;rv2.0b8pre) Gecko/20101102 Firefox/4.0b8pre
Fennec/4.0b3pre

And

Mozilla/5.0(Maemo; Linux armv7l;rv2.0b8pre) Gecko/20101102 Firefox/4.0b8pre
Fennec/4.0b3pre