598366 - remote logging with mochitest needs a little love for android and large files

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: fix stdout, logfiles, and file copy or remote mochitest (1.0)

In testing mochitest on android, I found a few issues with log file names and copying them.

With this patch and my mochikit.jar (bug 543800), I am running end to end mochitests (with a LOT of failures) on my android device.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: fix stdout, logfiles, and file copy or remote mochitest (1.1)

ok, ctalbert found a case that I didn't take care of.

for reference, here is a command line that should work:
python runtestsremote.py --app=org.mozilla.fennec --autorun --certificate-path=../certs --utility-path=../bin --xre-path=../firefox --http-port=9991 --ssl-port=9992 --close-when-done --deviceIP=192.168.1.101 --timeout=600 --test-path=content/xml --log-file=content-xml.log --remote-logfile=content-xml.log

You can also ignore the --remote-logfile cli argument and it will default to test.log and copy the results at the end into content-xml.log on the host machine.

Comment 2

[cmtalbert]

Actually this patch isn't complete.  It calls RemoteAutomation.setRemoteLog but you don't implement RemoteAutomation::setRemoteLog in this patch.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Just for the record, this was landed in bug 595294.  I believe Clint had a different repo checked out when he was looking into this issue.  He has verified this patch works as expected.

Comment 4

[Robert Sayre]

So, is this bug fixed?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

oh, wait.  My comment #3 was confusing as it was discussing the missing function in Comment #2.  This patch hasn't landed yet...let me double check for bitrot

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

ok, no bitrot.

Comment 7

[Robert Sayre]

So, this patch is ready to land? Just trying to make sure I get this right.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

yes, this patch is waiting to land.  The confusion from comments #2/#3 were regarding a bad copy of mozilla-central.  This patch is ready to land with no bitrot (and only affects remote testing specific files)

Comment 9

[Robert Sayre]

Added here:

https://wiki.mozilla.org/LandingQueue#Landing_Queue_for_Mozilla-Central

Comment 10

[Robert Sayre]

(In reply to comment #9)
> Added here:
> 
> https://wiki.mozilla.org/LandingQueue#Landing_Queue_for_Mozilla-Central

well, that was naive of me. I just pushed it on my own:

http://hg.mozilla.org/mozilla-central/rev/3b74162fcbf5