59848 - Autofill items appear in context menus of all elements in pages with forms

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Blake Ross]

Build ID: new trunk

The `Prefill Form' and `Save Form Data' items appear in the context menus of 
any pages that contain form elements.  `Prefill Form' certainly shouldn't be 
there when there's nothing to prefill (we've got bug 48923 to disable the item 
in the Edit menu under those circumstances, but it shouldn't be in the context 
menu at all in this case, imo.  Although maybe that's a little inconsistent.  
Matthew, what do you think?).

Still, even when there's form data to prefill and save, these items certainly 
should not be in the context menus for all nodes (links, images, etc.)  I 
suppose they should only be present in the page context menu and the context 
menu(s) of the form element(s) to prefill/save.  What do you guys think?

Comment 1

[Matthew T (active 1999-2002)]

The context menu for a non-form element certainly shouldn't have form-related 
items.

As for the context menu for elements in a form which is not (yet) prefillable or 
saveable -- Mac weenies are going to disagree with me, but I think the autofill 
items should still be there, disabled. Having the items disabled provides a 
useful indicator that the form is not prefillable or saveable; whereas removing 
the items completely will just cause the user to think that perhaps they were 
mistaken in thinking that the items were *ever* in the context menu.

Comment 2

[Blake Ross]

Should the items be in the page context menu?  I'm wondering if most users are 
going to distinguish between a page and a form element wrt what constitutes a 
`form' (and since those items apply to the entire form and not just the 
specific form element...).  I dunno.

Comment 3

[Matthew T (active 1999-2002)]

Yes, if they are going to prefill a form using the context menu, they are going 
to invoke the context menu from a form element. In fact I think it won't really 
occur to them that they can prefill the whole form at once, until they have 
actually opened the context menu.

Comment 4

[sairuh (rarely reading bugmail)]

adding self since this affects the content within context menus.

Comment 5

[Marcia Knous [:marcia]]

Netscape nav triage team: based on Steve Morse's pre-triage recommendation, this 
is not a beta stopper.

Comment 6

[Karl Ove Hufthammer]

I agree that the autofill option should be displayed on all context menus, but 
disabled when there's nothing to autofill/prefill/whatever.

I also think that it should be available from *both* page and form context 
menus, but not other context menus (e.g. right-clicking on an image).

Comment 7

[Stephen P. Morse]

With changes made recently, the item is indeed disabled if there is nothing to 
prefill.  So I'm closing this out as fixed.