598526 - regression: After opening a link from another app, back button should go back to that app

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
0. Set Fennec as your default browser.
1. Open Fennec.
2. Switch to another app like Twitter or GMail.
3. In the other app, open a link in Fennec.
4. Press back.

Expected results: The previous app is brought back to the front.

Actual results: The new tab is closed, and Fennec remains in the foreground.

This used to work but it has regressed, possibly by my patch in bug 515409.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Fixed a bug in the previous patch.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477372 [details] [diff] [review]
patch v2


>-      win.browserDOMWindow.openURI(uris[i], null, Ci.nsIBrowserDOMWindow.OPEN_NEWTAB, null);
>+      win.browserDOMWindow.openURI(uris[i], null, Ci.nsIBrowserDOMWindow.OPEN_NEWTAB,
>+                                   Ci.nsIBrowserDOMWindow.OPEN_EXTERNAL);

No need to wrap

I don't think this would affect unit tests, but we can cross that bridge later.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/abaf7a379574

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (android Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2

Comment 5

[Ayan Shah[:ashah]]

https://litmus.mozilla.org/show_test.cgi?id=13821