598556 - Ability to filter the pushlog by rev id

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

It would be nice to be able to filter the pushlog to show only a push containing a specific revision.

The attached patch let the user specify "rev=" in the URL to filter the pushlog to a specific revision.

Comment 1

[Arpad Borsos [:Swatinem]]

Comment on attachment 477404 [details] [diff] [review]
Patch v1

>+++ b/js/PushlogJSONParser.js
>+          // Look at the 12 first nodes characters when filtering by revision.
>+          if (rev && patch.node.substring(0, 12) == rev) {
>+            revFound = true;
>+          }
…
>           patches.unshift({rev: patch.node.substr(0,12), author: author,
>                   desc: Controller.stripTags(patch.desc), tags: tags});

Just for consistency, we should use the same function in both places (substr vs substring, I don’t care which one). You can also make it a var in the function so we avoid that redundancy alltogether.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

Comment 3

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/4450f4f7e9c1

Comment 4

[Markus Stange [:mstange]]

Deployed. Thanks Mounir!

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This doesn't actually seem to work -- e.g.

http://tests.themasta.com/tinderboxpushlog/?tree=MozillaTry&rev=15e65c1f91da doesn't show any results, even though the push certainly happened.

Comment 7

[Mounir Lamouri (:mounir)]

This has been broken by another commit and should be fixed by this one according to Arpad:
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/58f485db128d

Comment 8

[Markus Stange [:mstange]]

(In reply to comment #6)
> This doesn't actually seem to work -- e.g.
> 
> http://tests.themasta.com/tinderboxpushlog/?tree=MozillaTry&rev=15e65c1f91da
> doesn't show any results, even though the push certainly happened.

It only shows the push if it's in the time range that would be displayed without the rev argument. Automatically going back into time isn't implemented yet.