bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Don't rename pixman functions when system pixman is in use

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(blocking2.0 -)

Details

Attachments

(3 attachments)

(Assignee)

Description

8 years ago
Created attachment 477414 [details] [diff] [review]
Don't rename pixman when system pixman option is in use

On attempt to investigate bug 598531, bug 597336... I tried to compile system pixman. but that fail, due to rename pixman functions.
Attachment #477414 - Flags: review?(jmuizelaar)
(Assignee)

Comment 1

8 years ago
Dougt has this problem recently... unresolved symbols e.t.c....
Jeff does it looks good?
(Assignee)

Comment 2

8 years ago
Created attachment 478855 [details] [diff] [review]
Also we need pixman.h to make sys pixman functions visible
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #478855 - Flags: review?(jmuizelaar)
Attachment #477414 - Flags: review?(jmuizelaar) → review+
Attachment #478855 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 3

8 years ago
I thinks this should be safe
blocking2.0: --- → ?
blocking2.0: ? → -

Comment 4

8 years ago
approval2.0?

Updated

8 years ago
Attachment #477414 - Flags: approval2.0+

Updated

8 years ago
Attachment #478855 - Flags: approval2.0+

Comment 5

8 years ago
before pushing to m-c, make sure you pass try and there are no build problems.
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

8 years ago
Created attachment 480850 [details] [diff] [review]
PUSHME, combined patch with right header and approval flag
(Assignee)

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/52dfcbe2784e
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.