598643 - maxlength attribute should not apply to all input types

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alex]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100922 Firefox/4.0b7pre
Build Identifier: 

The maxlength attribute applies to <input type="file"> fields, causing them to block the form they are associated with from being submitted.

From the reading the spec, I gather this isn't supposed to happen (it's supposed to be ignored), the documentation on the MDC also says this.

https://developer.mozilla.org/en/HTML/Element/input#attr-maxlength

Reproducible: Always

Steps to Reproduce:
1. Open data:text/html,<input type="file" maxlength="1">
2. Select a random file
3. Notice it gets the red box-shadow specifying it's "invalid"
Actual Results:  
maxlength attribute is ignored, control isn't marked invalid.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This needs to block, I think.  Mounir, please fix?

Comment 2

[Mounir Lamouri (:mounir)]

Ok, the problem is maxlength should only apply to some types and we are checking maxlength whatever the type is, which is wrong.

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

This was also applying to other input types in some cases like:
<input type='text' id='i' maxlength='1'>
<script>
  document.getElementById('i').value = "foo";
  document.getElementById('i').type = "radio";
</script>

Comment 4

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/ee041d5c9198