Closed Bug 598695 Opened 14 years ago Closed 14 years ago

Missing OOM checking in js_ConcatStrings

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 596988
Milestone:
mozilla2.0

People

(Reporter: brendan, Unassigned)

References

Details

See bug 571549 comment 19. Easy to fix, needs fixing. Alan, do you have time to take this bug? If not, push back and someone will take it. /be
My patch in bug 596988, comment 3 (which was already reviewed, but not pushed) fixes any missing OOM-checking problems in js_ConcatStrings that I'm aware of. Does this bug refer to that, or something else? I don't see where bug 571549 comment 19 refers to an unchecked OOM.
(In reply to comment #1) > My patch in bug 596988, comment 3 (which was already reviewed, but not pushed) > fixes any missing OOM-checking problems in js_ConcatStrings that I'm aware of. Whoops, I should have remembered that bug. But you still have else-after-return all over in that patch. > Does this bug refer to that, or something else? I don't see where bug 571549 > comment 19 refers to an unchecked OOM. Er, comment 31 was what I meant to reference. /be
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.