Closed Bug 598696 Opened 16 years ago Closed 16 years ago

JM: FrameState::forgetType doesn't check isTypeKnown

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dvander, Assigned: dvander)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

It was intended that callers of FrameState::forgetType know a type for the FE. This is not always true. It's usually used with local variables, which are always forgotten in the presence of eval. bug 591836 exposed this problem, since it corrects a few cases where FrameState::storeLocal didn't sync a slot.
Attached patch fix — — Splinter Review
Attached test case will crash on tip.
Attachment #477568 - Flags: review?(sstangl)
Attachment #477568 - Flags: review?(sstangl) → review+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Blocks: 601109
No longer blocks: 601109
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: