598823 - Consider backing out bug 518122 if it makes us faster.

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

See bug 190147 comment 40 and 43.  It may in fact makes us faster if we revert the changes made as part of bug 518122.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Not appending would regress textarea.value+= badly, I thin
And we need StringBeginsWith for appending.

I'm about to test this.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

So if I comment out the code bug 518122 added, the testcase for bug 190147 (1000 
iterations) goes up from the current 0.4 to 1.88.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

And the testcase for bug 518122, from 564ms to 1542ms

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Marking wontfix, but feel free to reopen if you think there is still
some reason to consider backing out bug 518122.

Comment 5

[(no longer active)]

(In reply to comment #4)
> Marking wontfix, but feel free to reopen if you think there is still
> some reason to consider backing out bug 518122.

Just to check my sanity, you did test this on a tree with the patches to bug 240933, right?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I tested m-c today.

Comment 7

[(no longer active)]

(In reply to comment #6)
> I tested m-c today.

OK, thanks a lot for investigating this.  I concur with the WONTFIX decision here.