Closed Bug 598877 Opened 12 years ago Closed 12 years ago

.firstChild returns null for attributes even when .value has been set

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files)

Attached file testcase
This is a regression caused by bug 566416.

Tonight while Blake and I were debugging, Blake point this interesting bug in nsDOMAttributes. If you create an attribute and set its value then query for the firstChild, it will be null while it's the text node of the value in 3.6.
Summary: .firstChild returns null on attributes even when .value has been set → .firstChild returns null for attributes even when .value has been set
Attached patch Patch v1Splinter Review
All credits to Blake for this patch.
Attachment #477874 - Flags: review?(bzbarsky)
Comment on attachment 477874 [details] [diff] [review]
Patch v1

OK, but we really need to get rid of all this "attribute node" junk.  :(
Attachment #477874 - Flags: review?(bzbarsky) → review+
This should block considering it's a regression.
blocking2.0: --- → ?
blocking2.0: ? → final+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/90438abc6b1f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.