598982 - change "context-menu" module to use EventEmitter event registration model

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Comment 1

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 2

[Myk Melez [:myk] [@mykmelez]]

It looks like this has already happened.  Please reopen if that's incorrect.

Comment 3

[Drew Willcoxon :adw]

AFAIK no work was ever done on this.  I think it was filed before context-menu was converted to e10s and item.onClick and item.onContext were removed from the API.

The only thing left is item.onMessage.  You have to specify onMessage in an item's constructor; you can't later do item.on("message", ...).  Reopening for that.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Drew: thanks for the clarification!

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/138

Pointer to Github pull-request

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 523053 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/138

Thanks Irakli, this is clever.  Please make the changes I indicated in the GitHub comments before landing.

Comment 7

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Thanks for review, landed.