599084 - Work-around bug 313700 for auto-updates to make flash-check report the right value

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to bug 514815 comment #45)
> So, this is really going to suck for users due to bug 313700 :( (it hit me
> tonight, and made me question my sanity, or my ability to do math).

(In reply to bug 514815 comment #47)
> To summarize from irc: for whatever reason, sometimes pluginreg.dat just never
> updates.  (In my case, I had physically removed the old Flash and installed the
> new one, so no matter what the "do-i-rebuild?" code was checking, it should
> have seen new timestamps.)  In this case, the bad data could persist through
> the next Camino update, which would cause the user to see an incorrect warning. 
> 
> Stuart suggested we could touch a bundle wrapper directory on quit for an
> autoupdate (but that wouldn't solve my problem), or nuke pluginreg.dat before
> autoupdates (which would be a bit sketchy, but maybe better than nothing).

Comment 1

[Stuart Morgan]

Attachment: workaround

Delete pluginreg.dat on pre-auto-update-quit.

This isn't perfect, since it won't help manual updaters, but I feel a lot better about nuking a file during shutdown than I do nuking it after Gecko has started up (although it would *probably* work out in this case, since I think it's not read in until something uses plugins). Hopefully most people are auto-updating :)

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 478168 [details] [diff] [review]
workaround

+  // Partially hack around bug 313700 (pluginreg.dat not udpating). Since our

s/udpating/updating

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 478168 [details] [diff] [review]
workaround

sr=pink

Comment 4

[Stuart Morgan]

Landed http://hg.mozilla.org/camino/rev/a6d47e9da999.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

CAMINO_2_0_BRANCH for 2.0.5.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

For historical reference, we fixed this in a more comprehensive way in bug 740620.