599104 - URL progress moves LTR in RTL mode

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Conflicting Progress Screenshot

The new URL progress bar moves LTR when in RTL mode while background tab progress moves RTL.

STR:
- Put browser in RTL mode
- Navigate or refresh a page
- Watch progress go LTR
- Refresh a background tab
- Watch progress go RTL

Expected:
- All progress bars should move RTL

Comment 1

[Csaba Kozák [:WonderCsabo]]

I feel stupid now, but how can i put the browser into right to left mode? Or is this a Mac only feature? (I'm on Win)

Comment 2

[(no longer active)]

(In reply to comment #1)
> I feel stupid now, but how can i put the browser into right to left mode? Or is
> this a Mac only feature? (I'm on Win)

Try the Force RTL add-on!

Comment 3

[Csaba Kozák [:WonderCsabo]]

Thanks! I tried. It doesnt WFM. :S 

Fresh profile, Win7.
buildconfig: http://hg.mozilla.org/mozilla-central/rev/36a9ff4549cc

Note: I tried on en-US Minefield, and hu-HU Fx 3.6.10, too. Not worked with any version.

Comment 4

[:Margaret Leibovic]

Attachment: patch

This fixes the problem.

As a side note, the progress meter in the status bar also moved LTR in RTL mode. Was that a bug, or was that intentional?

Comment 5

[Dão Gottwald [:dao]]

> As a side note, the progress meter in the status bar also moved LTR in RTL
> mode. Was that a bug, or was that intentional?

Sounds like a bug, but I don't really know.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 478283 [details] [diff] [review]
patch

This is fine code-wise, but I don't know what the expected behavior for progress bars is.

Comment 7

[(no longer active)]

(In reply to comment #4)
> As a side note, the progress meter in the status bar also moved LTR in RTL
> mode. Was that a bug, or was that intentional?

That was a bug.

Comment 8

[(no longer active)]

This is not blocking yet, so you should request approval2.0 on the patch./

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

This is now blocking beta 7, neener-neener.

Comment 10

[(no longer active)]

I'll land it if the tree is ever green.

Comment 11

[(no longer active)]

Attachment: For check-in

Comment 12

[Nochum Sossonko [:Natch]]

This was checked in already.

Comment 13

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/cd8b5689ffbf