599148 - Split testPasswordNotSaved.js into two modules

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

File: firefox/testPasswordManager/testPasswordNotSaved.js

This test module consists of two tests:
 * testPasswordNotificationBar()
 * testPasswordNotSaved()

These should be split into two separate test modules.  I recommend moving testPasswordNotificationBar() to its own module.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Vlad, that's one of the tests we have to split out.

Comment 3

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13242923

Comment 4

[Maniac Vlad Florin (:vladmaniac)]

Attachment: Patch v1.0

Comment 5

[Maniac Vlad Florin (:vladmaniac)]

Comment on attachment 531617 [details] [diff] [review]
Patch v1.0

Review of attachment 531617 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[u279076]

Comment on attachment 531617 [details] [diff] [review]
Patch v1.0

Review of attachment 531617 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me -- tested ok on Mac. r+

Over to Henrik for additional review.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 531617 [details] [diff] [review]
Patch v1.0

Thanks for the patch Vlad. There are only some small things we should do.

>+++ b/tests/functional/testPasswordManager/testPasswordNotificationBar.js	Wed May 11 16:27:12 2011 +0300
>+ * Portions created by the Initial Developer are Copyright (C) 2009

Please use 2011 here.

The PasswordNotSaved test doesn't use the locationbar class, so we can remove the inclusion of the lib and any other trace.

Also please delete the comments for the litmus meta data, those are simply wrong and we don't use them anymore.

Thanks.

Comment 8

[Maniac Vlad Florin (:vladmaniac)]

Attachment: Patch v1.1

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 531911 [details] [diff] [review]
Patch v1.1

Looks fine. Only one nit, please export the patch the next time so it already contains your user information. See our documentation how to do that.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/792ecdd366ad (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/61ec80bc191c (aurora)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Vlad, can you also please update the Litmus tests if not done yet?

Comment 12

[Maniac Vlad Florin (:vladmaniac)]

This test covers https://litmus.mozilla.org/show_test.cgi?id=15983. Marking as fixed.

Comment 13

[Maniac Vlad Florin (:vladmaniac)]

Also test https://litmus.mozilla.org/show_test.cgi?id=15639

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Also pushed to beta:
http://hg.mozilla.org/qa/mozmill-tests/rev/2609a3b841bb