Add-ons cannot be installed from FTP servers

VERIFIED FIXED in mozilla2.0b7

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

({regression})

Trunk
mozilla2.0b7
regression
Points:
---
Bug Flags:
in-testsuite -
in-litmus +

Firefox Tracking Flags

(blocking2.0 beta8+)

Details

(Whiteboard: [mozmill-test-needed])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Bug 550936 accidentally added some code that assumes the download channel is HTTP.
(Assignee)

Updated

7 years ago
blocking2.0: --- → beta8+
Keywords: regression
(Assignee)

Comment 1

7 years ago
Created attachment 478105 [details] [diff] [review]
patch rev 1

I don't believe that we can automatically test this, there is no ftp test server, but I've manually checked it.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #478105 - Flags: review?(robert.bugzilla)
Attachment #478105 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [checkin-needed-post-b7]
(Assignee)

Updated

7 years ago
Whiteboard: [checkin-needed-post-b7] → [has patch][checkin-needed-post-b7]
(Assignee)

Comment 2

7 years ago
Fixed: http://hg.mozilla.org/mozilla-central/rev/0c55fdabe021

I think we should have a manual test for installing from ftp sites.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Flags: in-litmus?
Resolution: --- → FIXED
Whiteboard: [has patch][checkin-needed-post-b7]
Target Milestone: --- → mozilla2.0b8
(In reply to comment #1)
> I don't believe that we can automatically test this, there is no ftp test
> server, but I've manually checked it.

But we can test it with Mozmill outside of buildbot. Therefore I would suggest to use the ACR extension (ftp://ftp.mozilla.org/pub/mozilla.org/addons/15003/). By using querySelector we can get the latest version of that add-on and run a normal installation routine.
Whiteboard: [mozmill-test-needed]
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101008 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED

Updated

7 years ago
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Flags: in-litmus? → in-litmus?(vlad.maniac)
Manual test covered by:
https://litmus.mozilla.org/show_test.cgi?id=15219
Flags: in-litmus?(vlad.maniac) → in-litmus+
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.