Closed Bug 599158 Opened 14 years ago Closed 14 years ago

Add-ons cannot be installed from FTP servers

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b7
Tracking Flags:
Tracking Status
blocking2.0 --- beta8+

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: regression, Whiteboard: [mozmill-test-needed])

Attachments

(1 file)

patch rev 1
1.16 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
Bug 550936 accidentally added some code that assumes the download channel is HTTP.
blocking2.0: --- → beta8+
Attached patch patch rev 1 — — Splinter Review 
I don't believe that we can automatically test this, there is no ftp test server, but I've manually checked it.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #478105 - Flags: review?(robert.bugzilla)
Attachment #478105 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [checkin-needed-post-b7]
Whiteboard: [checkin-needed-post-b7] → [has patch][checkin-needed-post-b7]
Fixed: http://hg.mozilla.org/mozilla-central/rev/0c55fdabe021

I think we should have a manual test for installing from ftp sites.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus?
Resolution: --- → FIXED
Whiteboard: [has patch][checkin-needed-post-b7]
Target Milestone: --- → mozilla2.0b8
(In reply to comment #1)
> I don't believe that we can automatically test this, there is no ftp test
> server, but I've manually checked it.

But we can test it with Mozmill outside of buildbot. Therefore I would suggest to use the ACR extension (ftp://ftp.mozilla.org/pub/mozilla.org/addons/15003/). By using querySelector we can get the latest version of that add-on and run a normal installation routine.
Whiteboard: [mozmill-test-needed]
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101008 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Flags: in-litmus? → in-litmus?(vlad.maniac)
Manual test covered by:
https://litmus.mozilla.org/show_test.cgi?id=15219
Flags: in-litmus?(vlad.maniac) → in-litmus+
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: