599502 - Use of sleep() causes random failures/hangs in testMasterPassword

Status: VERIFIED WORKSFORME

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

File: firefox/restartTests/testMasterPassword/test1.js

  // Get the Remember Password button based on the above label              
  var button = tabBrowser.getTabPanelElement(
                 tabBrowser.selectedIndex,
                '/{"value":"password-save"}/{"label":"' + label + '"}'
               );

  UtilsAPI.assertElementVisible(controller, button, true);
  controller.waitThenClick(button, TIMEOUT);
  controller.sleep(500);
  controller.assertNodeNotExist(button);

The above sleep causes a failure sometimes in the Master Password test.  We should update the test to use a waitForEval instead.

Comment 1

[Aaron Train [:aaronmt]]

Alongside the above, the code pasted shouldn't even work because we can't use getTabPanelElement for an expected notification box anymore because it's now changed to a doorhanger. This bug should depend on an API change

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please file a bug if there isn't one yet, so we can get the TabbedBrowsingAPI updated.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 4

[u279076]

What's left for this bug? Simply refactor it to stop using sleep()?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I would leave it to you for now for investigation.

Comment 6

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> I would leave it to you for now for investigation.

I did not see any sleep call in this test. Perhaps we changed it in another bug and forgot to close this one? 

Anyway, the code in Description does not appear to be in the test files. 1.9.2 branch? 
There was no branch stated in the bug report so perhaps I am missing the branch

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yeah, i think that I have fixed that in another bug a long time ago. Can't remember which one. So closing as wfm.