Closed
Bug 599503
Opened 15 years ago
Closed 15 years ago
Return the true compartment info for getCompartment()
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta7+ |
People
(Reporter: gal, Assigned: gal)
References
Details
(Whiteboard: [compartments])
Attachments
(2 files)
|
14.14 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
|
14.07 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: general → gal
|
|
||
Updated•15 years ago
|
Attachment #478413 -
Flags: review+
|
||
Comment 2•15 years ago
|
||
This should also work. We don't need the JSObject::getCompartment indirection.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #478551 -
Flags: review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Gregor, can you test this? I was seeing weird test failures. Is everything out of the default compartment yet?
|
|
||
Comment 4•15 years ago
|
||
Yeah I saw some test failures on linux64 debug and win debug. Looking...(In reply to comment #3)
> Gregor, can you test this? I was seeing weird test failures. Is everything out
> of the default compartment yet?
Yeah I saw some test failures on linux64 debug and win debug. Looking...
|
|
Assignee | |
Comment 5•15 years ago
|
||
Thanks.
|
||
Updated•15 years ago
|
Whiteboard: [compartments]
|
||
Comment 6•15 years ago
|
||
Please note that we have now created a branch for beta 7 work. In addition to landing your fix on mozilla-central default, please also land it on mozilla-central GECKO20b7pre_20101006_RELBRANCH
(note: when landing on mozilla-central default, you will be given priority in the landing queue at https://wiki.mozilla.org/LandingQueue )
|
||
Comment 7•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•