599509 - Canceling add-on install from a listener triggers an exception

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ed Lee :Mardak]

Error: [Exception... "'Error: Cannot start installing from this state' when calling method: [mozIStorageStatementCallback::handleCompletion]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "<unknown>"  data: no]

sample code:

AddonManager.getInstallForURL(url, function(addon) {
  addon.addListener({
    onDownloadEnded: function() {
      addon.cancel();
    }
  });
  addon.install();
}, "application/x-xpiinstall");

If I return false from onDownloadEnded, there's no exception.

Comment 1

[Dave Townsend [:mossop]]

We should be checking that self.state is still STATE_DOWNLOADED before proceeding with the install in here: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/XPIProvider.jsm#4786.

I don't think this blocks as there is an easy solution, but I'd review and approve a patch with a test.

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

A little extra protection to stop us ending up in odd states, just check that we're still in the state we expect to be in after calling out to listeners that can change the state.

Comment 3

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/35dc1d30acf6

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Kinda hard to test this manually. I will have to trust the automated test. No regressions filed so far. Means I assume its fixed now.