CGI.pm compile options are different under mod_perl than normal

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Bugzilla-General
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

Bugzilla 4.2
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
When loading up CGI.pm in mod_perl.pl, the compile-time options are different than the options we normally get when loading up Bugzilla::CGI. This is why mod_perl installations start to generate URLs separated by semicolons instead of ampersands.
(Assignee)

Updated

8 years ago
Version: 3.6 → 3.0
(Assignee)

Comment 1

8 years ago
Created attachment 478476 [details] [diff] [review]
v1

This also does a bit of general cleanup of mod_perl.pl:

* Template.pm itself calls Template::Config->preload, under mod_perl, so we don't have to.
* We didn't need to be loading a lot of those modules--they were being loaded by "use Bugzilla;" anyhow.
* It's better to load Bugzilla::BugMail than Bugzilla::Mailer, since BugMail otherwise doesn't get loaded, and BugMail will load Mailer.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #478476 - Flags: review?(glob)
(Assignee)

Comment 2

8 years ago
Hey hey. Any chance of a review on this one? It's pretty simple.
Comment on attachment 478476 [details] [diff] [review]
v1

r=glob
Attachment #478476 - Flags: review?(glob) → review+
(Assignee)

Updated

8 years ago
Flags: approval+
(Assignee)

Comment 4

8 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified mod_perl.pl
Committed revision 7605.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.