599552 - CGI.pm compile options are different under mod_perl than normal

Status: RESOLVED FIXED

Description

[Max Kanat-Alexander]

When loading up CGI.pm in mod_perl.pl, the compile-time options are different than the options we normally get when loading up Bugzilla::CGI. This is why mod_perl installations start to generate URLs separated by semicolons instead of ampersands.

Comment 1

[Max Kanat-Alexander]

Created attachment 478476 [details] [diff] [review]
v1

This also does a bit of general cleanup of mod_perl.pl:

* Template.pm itself calls Template::Config->preload, under mod_perl, so we don't have to.
* We didn't need to be loading a lot of those modules--they were being loaded by "use Bugzilla;" anyhow.
* It's better to load Bugzilla::BugMail than Bugzilla::Mailer, since BugMail otherwise doesn't get loaded, and BugMail will load Mailer.

Comment 2

[Max Kanat-Alexander]

Hey hey. Any chance of a review on this one? It's pretty simple.

Comment 3

[Byron Jones ‹:glob› 🎈]

Comment on attachment 478476 [details] [diff] [review]
v1

r=glob

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified mod_perl.pl
Committed revision 7605.