Closed
Bug 599573
Opened 14 years ago
Closed 14 years ago
Only allow one about window to check for / download / etc. updates
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: robert.strong.bugs, Assigned: Margaret)
References
Details
Attachments
(1 file)
710 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Just realized that multiple about window's can be opened and they can conflict with one another when checking for updates or downloading an update.
Reporter | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Updated•14 years ago
|
blocking2.0: ? → final+
Assignee | ||
Comment 1•14 years ago
|
||
(In reply to comment #0) > Just realized that multiple about window's can be opened and they can conflict > with one another when checking for updates or downloading an update. Really? I tried opening additional about windows, but the "About Minefield" menuitem just brought focus back to the original about window. I tested this on Windows 7 and OSX.
Reporter | ||
Comment 2•14 years ago
|
||
Open a second window first
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > Open a second window first Ah, that does it on Windows. However, on Linux and OSX selecting the menuitem still brings focus back to the original about window. Should we just replicate this behavior on Windows? I don't think it makes much sense for multiple about windows to exist, and that would solve the problem of multiple about windows checking for updates.
Assignee: nobody → margaret.leibovic
OS: All → Windows 7
Comment 4•14 years ago
|
||
> Should we just replicate this behavior on Windows? I don't think it makes much
> sense for multiple about windows to exist, and that would solve the problem of
> multiple about windows checking for updates.
Yes.
Assignee | ||
Comment 5•14 years ago
|
||
I'm not sure if this is a hacky fix, but it fixes the problem.
Attachment #485080 -
Flags: review?(dolske)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [needs review dolske]
Comment 6•14 years ago
|
||
Comment on attachment 485080 [details] [diff] [review] patch Bouncing this over to gavin, this this code was just changed (after much discussion) in bug 417733. But my $0.02 here is that we should just take this patch. It's just an About window, so it's hard for me to get too worked up about how it should behave.
Attachment #485080 -
Flags: review?(dolske) → review?(gavin.sharp)
Updated•14 years ago
|
Attachment #485080 -
Flags: review?(gavin.sharp) → review+
Updated•14 years ago
|
Whiteboard: [needs review dolske]
Assignee | ||
Updated•14 years ago
|
Whiteboard: [can land]
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/85619a58a99e
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
You need to log in
before you can comment on or make changes to this bug.
Description
•