Closed Bug 599573 Opened 14 years ago Closed 14 years ago

Only allow one about window to check for / download / etc. updates

Categories

(Firefox :: General, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: robert.strong.bugs, Assigned: Margaret)

References

Details

Attachments

(1 file)

Just realized that multiple about window's can be opened and they can conflict with one another when checking for updates or downloading an update.
blocking2.0: --- → ?
blocking2.0: ? → final+
(In reply to comment #0)
> Just realized that multiple about window's can be opened and they can conflict
> with one another when checking for updates or downloading an update.

Really? I tried opening additional about windows, but the "About Minefield" menuitem just brought focus back to the original about window. I tested this on Windows 7 and OSX.
Open a second window first
(In reply to comment #2)
> Open a second window first

Ah, that does it on Windows. However, on Linux and OSX selecting the menuitem still brings focus back to the original about window.

Should we just replicate this behavior on Windows? I don't think it makes much sense for multiple about windows to exist, and that would solve the problem of multiple about windows checking for updates.
Assignee: nobody → margaret.leibovic
OS: All → Windows 7
> Should we just replicate this behavior on Windows? I don't think it makes much
> sense for multiple about windows to exist, and that would solve the problem of
> multiple about windows checking for updates.

Yes.
Attached patch patchSplinter Review
I'm not sure if this is a hacky fix, but it fixes the problem.
Attachment #485080 - Flags: review?(dolske)
Whiteboard: [needs review dolske]
Comment on attachment 485080 [details] [diff] [review]
patch

Bouncing this over to gavin, this this code was just changed (after much discussion) in bug 417733.

But my $0.02 here is that we should just take this patch. It's just an About window, so it's hard for me to get too worked up about how it should behave.
Attachment #485080 - Flags: review?(dolske) → review?(gavin.sharp)
Attachment #485080 - Flags: review?(gavin.sharp) → review+
Whiteboard: [needs review dolske]
Whiteboard: [can land]
http://hg.mozilla.org/mozilla-central/rev/85619a58a99e
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: