Closed Bug 599587 Opened 12 years ago Closed 12 years ago
Be smarter about our string buffer caching in document encoder
Right now we always make a copy into the output string, even if we plan to not cache the stringbuffer. We should just use it in those cases instead.
Comment on attachment 478515 [details] [diff] [review] Proposed fix This does seem to speed up the Zimbra preferences tests by a percent or maybe two.... hard to tell with all the noise. :(
Attachment #478515 - Flags: review?(Olli.Pettay)
Priority: -- → P1
Whiteboard: [need review]
Comment on attachment 478515 [details] [diff] [review] Proposed fix There is now 2 if (mCachedBuffer) checks. Could you add an |if (mCachedBuffer)| around the if-else.
Attachment #478515 - Flags: review?(Olli.Pettay) → review+
Attachment #478515 - Attachment is obsolete: true
Comment on attachment 481150 [details] [diff] [review] With that change Looking for approval for this performance fix
Attachment #481150 - Flags: approval2.0?
Whiteboard: [need review] → [need approval]
Attachment #481150 - Flags: approval2.0? → approval2.0+
Whiteboard: [need approval] → [need landing]
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.