Closed Bug 599604 Opened 14 years ago Closed 14 years ago

Implement LocationWrapper

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jorendorff, Assigned: gal)

References

Details

Attachments

(1 file, 2 obsolete files)

In xpcconvert.cpp, in NativeInterface2JSObject, where we currently call ClassNeedsXOW, the new code will still need to do something special for the Location object. This requires a slightly custom wrapper (but mostly just like a XOW).
Blocks: compartments
Attached patch WIP 1 (obsolete) — Splinter Review
With this patch, AccessCheck::isLocationObjectSameOrigin asks the SecurityManager for the Location object's object principal. That's what we currently do, I think, but it's not what we want to do long-term. Is there already a way to ask a Location object what compartment or inner window the outer window is currently navigated to? If not, can I add a non-scriptable method on nsIDOMLocation?
Attachment #478525 - Flags: feedback?(mrbkap)
Attached patch patch (obsolete) — Splinter Review
Assignee: jorendorff → gal
Attachment #478525 - Attachment is obsolete: true
Attachment #478525 - Flags: feedback?(mrbkap)
Attached patch patchSplinter Review
Attachment #479276 - Attachment is obsolete: true
This is in the queue now.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: