Closed Bug 599621 Opened 10 years ago Closed 10 years ago

Fix some reminding/missed issues regarding personas and sidebar

Categories

(SeaMonkey :: Themes, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file)

I missed 2 things when I reviewed the patch in bug 581382

1) We need "text-shadow: none;" for the box-texttab on mac
2) .sidebarheader-main has "-moz-appearance: toolbar;". This means that the border styles are not applied. With personas we set "moz-appearance: none;" - that means that borders are applied and the box increase in size (moves). This can be seen when previewing personas.
Blocks: 581382
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #478590 - Flags: review?(mnyromyr)
-  border: 1px outset InactiveCaption;

Just to clarify: this border style doesn't make sense when you have a -moz-appearance rule, so we can just get rid of of it. Even if we didn't had any -moz-appearance rule it shouldn't be there imo since it would look bad.
Comment on attachment 478590 [details] [diff] [review]
fix remaining issues on mac

I'll steal that as I just believe you on that border and the other hunk is already agreed anyhow ;-)
Attachment #478590 - Flags: review?(mnyromyr) → review+
http://hg.mozilla.org/comm-central/rev/5502075d82b1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.