The default bug view has changed. See this FAQ.

Fix some reminding/missed issues regarding personas and sidebar

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b1
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
I missed 2 things when I reviewed the patch in bug 581382

1) We need "text-shadow: none;" for the box-texttab on mac
2) .sidebarheader-main has "-moz-appearance: toolbar;". This means that the border styles are not applied. With personas we set "moz-appearance: none;" - that means that borders are applied and the box increase in size (moves). This can be seen when previewing personas.
(Assignee)

Updated

7 years ago
Blocks: 581382
(Assignee)

Comment 1

7 years ago
Created attachment 478590 [details] [diff] [review]
fix remaining issues on mac
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #478590 - Flags: review?(mnyromyr)
(Assignee)

Comment 2

7 years ago
-  border: 1px outset InactiveCaption;

Just to clarify: this border style doesn't make sense when you have a -moz-appearance rule, so we can just get rid of of it. Even if we didn't had any -moz-appearance rule it shouldn't be there imo since it would look bad.

Comment 3

7 years ago
Comment on attachment 478590 [details] [diff] [review]
fix remaining issues on mac

I'll steal that as I just believe you on that border and the other hunk is already agreed anyhow ;-)
Attachment #478590 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/comm-central/rev/5502075d82b1
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.