599621 - Fix some reminding/missed issues regarding personas and sidebar

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

I missed 2 things when I reviewed the patch in bug 581382

1) We need "text-shadow: none;" for the box-texttab on mac
2) .sidebarheader-main has "-moz-appearance: toolbar;". This means that the border styles are not applied. With personas we set "moz-appearance: none;" - that means that borders are applied and the box increase in size (moves). This can be seen when previewing personas.

Comment 1

[Stefan [:stefanh]]

Attachment: fix remaining issues on mac

Comment 2

[Stefan [:stefanh]]

-  border: 1px outset InactiveCaption;

Just to clarify: this border style doesn't make sense when you have a -moz-appearance rule, so we can just get rid of of it. Even if we didn't had any -moz-appearance rule it shouldn't be there imo since it would look bad.

Comment 3

[Robert Kaiser]

Comment on attachment 478590 [details] [diff] [review]
fix remaining issues on mac

I'll steal that as I just believe you on that border and the other hunk is already agreed anyhow ;-)

Comment 4

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/5502075d82b1