Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 599621 - Fix some reminding/missed issues regarding personas and sidebar
: Fix some reminding/missed issues regarding personas and sidebar
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Stefan [:stefanh]
Depends on:
Blocks: 581382
  Show dependency treegraph
Reported: 2010-09-25 08:20 PDT by Stefan [:stefanh]
Modified: 2010-09-26 04:56 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

fix remaining issues on mac (1.24 KB, patch)
2010-09-25 15:38 PDT, Stefan [:stefanh]
kairo: review+
Details | Diff | Splinter Review

Description Stefan [:stefanh] 2010-09-25 08:20:13 PDT
I missed 2 things when I reviewed the patch in bug 581382

1) We need "text-shadow: none;" for the box-texttab on mac
2) .sidebarheader-main has "-moz-appearance: toolbar;". This means that the border styles are not applied. With personas we set "moz-appearance: none;" - that means that borders are applied and the box increase in size (moves). This can be seen when previewing personas.
Comment 1 Stefan [:stefanh] 2010-09-25 15:38:53 PDT
Created attachment 478590 [details] [diff] [review]
fix remaining issues on mac
Comment 2 Stefan [:stefanh] 2010-09-25 15:46:32 PDT
-  border: 1px outset InactiveCaption;

Just to clarify: this border style doesn't make sense when you have a -moz-appearance rule, so we can just get rid of of it. Even if we didn't had any -moz-appearance rule it shouldn't be there imo since it would look bad.
Comment 3 Robert Kaiser 2010-09-25 16:47:31 PDT
Comment on attachment 478590 [details] [diff] [review]
fix remaining issues on mac

I'll steal that as I just believe you on that border and the other hunk is already agreed anyhow ;-)
Comment 4 Stefan [:stefanh] 2010-09-26 04:56:07 PDT

Note You need to log in before you can comment on or make changes to this bug.