Closed
Bug 599737
Opened 14 years ago
Closed 14 years ago
Fully end-of-life Python 2.4 for build support
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file)
2.04 KB,
patch
|
ted
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•14 years ago
|
||
While there, just tell me whether you want to add support for 'python2.7' (directory) or not.
Attachment #478642 -
Flags: review?(ted.mielczarek)
Comment 2•14 years ago
|
||
Comment on attachment 478642 [details] [diff] [review] (Av1) Remove remnants in configure.in [Checked in: See comment 10] >-dnl We require version 2.4 or newer of Python to build, >-dnl and 2.5 or newer on Windows. Can you just fix this comment to be correct with respect to what we currently require? Feel free to add python2.7 to the list of binary names we look for. r=me with that comment change.
Attachment #478642 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 478642 [details] [diff] [review] (Av1) Remove remnants in configure.in [Checked in: See comment 10] "approval2.0=?": Trivial configure cleanup, zero risk.
Attachment #478642 -
Flags: approval2.0?
Comment 4•14 years ago
|
||
The patch does not change PYTHON_VERSION=2.4 to 2.5. Is this intended? http://mxr.mozilla.org/mozilla1.9.2/source/configure.in#121 http://mxr.mozilla.org/mozilla2.0/source/configure.in#123
It already is on trunk. http://mxr.mozilla.org/mozilla-central/source/configure.in#121
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #4) I never implied that I would be targeting m-1.9.2. m-2.0 isn't up-to-date: "Thu Jun 03 11:26:32 2010 -0700".
Assignee | ||
Comment 7•14 years ago
|
||
Comment on attachment 478642 [details] [diff] [review] (Av1) Remove remnants in configure.in [Checked in: See comment 10] http://hg.mozilla.org/mozilla-central/rev/6946b5d25ac3 Av1, with comment 2 suggestion(s).
Attachment #478642 -
Attachment description: (Av1) Remove remnants in configure.in → (Av1) Remove remnants in configure.in
[Checked in: See comment 7]
Attachment #478642 -
Flags: approval2.0?
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Comment 8•14 years ago
|
||
I backed out all the changesets in your push because they weren't approved.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•14 years ago
|
||
Comment on attachment 478642 [details] [diff] [review] (Av1) Remove remnants in configure.in [Checked in: See comment 10] (In reply to comment #8) > I backed out all the changesets in your push because they weren't approved. See discussion in bug 595756 :-<
Attachment #478642 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #478642 -
Attachment description: (Av1) Remove remnants in configure.in
[Checked in: See comment 7] → (Av1) Remove remnants in configure.in
[Checked in: See comment 7]
Attachment #478642 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 10•14 years ago
|
||
Comment on attachment 478642 [details] [diff] [review] (Av1) Remove remnants in configure.in [Checked in: See comment 10] http://hg.mozilla.org/mozilla-central/rev/08f79fca7386
Attachment #478642 -
Attachment description: (Av1) Remove remnants in configure.in
[Checked in: See comment 7] → (Av1) Remove remnants in configure.in
[Checked in: See comment 10]
Assignee | ||
Updated•14 years ago
|
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•13 years ago
|
||
(In reply to comment #8) > I backed out all the changesets in your push because they weren't approved. http://hg.mozilla.org/mozilla-central/rev/6946b5d25ac3
Assignee | ||
Comment 12•13 years ago
|
||
(In reply to comment #11) > (In reply to comment #8) > > I backed out all the changesets in your push because they weren't approved. > > http://hg.mozilla.org/mozilla-central/rev/6946b5d25ac3 http://hg.mozilla.org/mozilla-central/rev/ea371c9d775b !
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•