Closed
Bug 599798
Opened 14 years ago
Closed 14 years ago
rotate attribute of <svg:text> is not live
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: takenspc, Assigned: takenspc)
References
Details
Attachments
(2 files, 4 obsolete files)
1.32 KB,
image/svg+xml
|
Details | |
4.00 KB,
patch
|
Details | Diff | Splinter Review |
Rotate attribute of <svg:text> or <svg:tspan> is not live to changes. Patch upcoming
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #478719 -
Flags: review?(longsonr)
Updated•14 years ago
|
Attachment #478718 -
Flags: review?(longsonr) → review+
Updated•14 years ago
|
Attachment #478719 -
Flags: review?(longsonr) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Requesting 2.0 approval. This is small and fixes SVG DOM manipulation bug.
Attachment #479010 -
Flags: approval2.0?
Comment 4•14 years ago
|
||
roc can you approve this please? It's got tests and is only one line. It fixes a bug in our "new and improved" text positioning. Takeshi, I think you missed the reftest in your roll up patch but it's there in comment 1.
Attachment #479010 -
Flags: approval2.0? → approval2.0+
Comment 5•14 years ago
|
||
Attachment #478718 -
Attachment is obsolete: true
Attachment #478719 -
Attachment is obsolete: true
Attachment #479010 -
Attachment is obsolete: true
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
Updated•14 years ago
|
Attachment #482942 -
Attachment description: hg hangeset patch → hg changeset patch
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e16a93bf622d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
Comment 7•14 years ago
|
||
Backed out on suspicion of causing bug 604415: http://hg.mozilla.org/mozilla-central/rev/12d40eb13315
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•14 years ago
|
||
"suspicion" confirmed -- just now noticed that the test was new in this bug's changeset, so of course the failures started with this changeset. :) The test is "dynamic-text-04.svg", and it failed 10 assertions on the Linux (32 and 64-bit) debug builds: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287074516.1287075940.2685.gz and 6 assertions on Mac (32 and 64-bit) debug builds: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287074208.1287075893.2288.gz Looks like it had no assertion-failures on the Windows debug build, though, for some reason: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287075691.1287078702.14445.gz
Comment 9•14 years ago
|
||
Seems to me there are 3 ways of fixing this... a) find a font that does not have ligatures and use that b) fix bug 468035 c) add the appropriate number of asserts to the reftest Currently trying b) on the try server. That should fix Mac but may not fix Linux.
Comment 10•14 years ago
|
||
OK b) is done and needs to land when this relands so I'll disable the reftest on Linux for now.
Comment 11•14 years ago
|
||
skip reftest on linux for the moment
Attachment #482942 -
Attachment is obsolete: true
Comment 12•14 years ago
|
||
checked in http://hg.mozilla.org/mozilla-central/rev/18b13b7f0959
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 13•14 years ago
|
||
Anyone looking for Fix viewBox on pattern with patternContentUnits=objectBoundingBox should look at bug 605022. I accidentally set this bugs number with that bugs check-in.
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•