tabbrowser-alltabs-popup should hide over-link when an about:blank menuitem is active

RESOLVED FIXED in Firefox 4.0b7

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

Trunk
Firefox 4.0b7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Posted patch patch (obsolete) — Splinter Review
For about:blank tabs, tabbrowser-alltabs-popup sets the over-link to a single space, which "cleared" the status bar when the over-link used to be shown there.  But since the over-link is now shown in the location bar, a single space causes the over-link to appear as a single space.  setOverLink should now be passed a falsey value to hide the over-link instead.

(Or setOverLink could trim the string it's passed.  Or we could just show "about:blank" like we do for about:home, about:addons, etc.)
Attachment #478740 - Flags: review?(gavin.sharp)
Comment on attachment 478740 [details] [diff] [review]
patch

>         if (tab) {

>+          var overLink = tab.linkedBrowser.currentURI.spec;

nit: let

>+          if (overLink == "about:blank")
>+            overLink = null;
>+          XULBrowserWindow.setOverLink(overLink, null);

The first argument is supposed to be a string.
Attachment #478740 - Flags: review?(gavin.sharp) → review-
(Assignee)

Comment 2

9 years ago
Posted patch patch 2Splinter Review
Attachment #478740 - Attachment is obsolete: true
Attachment #479006 - Flags: review?(dao)
Attachment #479006 - Flags: review?(dao) → review+
(Assignee)

Comment 3

9 years ago
Comment on attachment 479006 [details] [diff] [review]
patch 2

Requesting approval2.0, simple low-risk fix.
Attachment #479006 - Flags: approval2.0?
Attachment #479006 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/ca1457ab42da
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in before you can comment on or make changes to this bug.