599827 - tabbrowser-alltabs-popup should hide over-link when an about:blank menuitem is active

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

For about:blank tabs, tabbrowser-alltabs-popup sets the over-link to a single space, which "cleared" the status bar when the over-link used to be shown there.  But since the over-link is now shown in the location bar, a single space causes the over-link to appear as a single space.  setOverLink should now be passed a falsey value to hide the over-link instead.

(Or setOverLink could trim the string it's passed.  Or we could just show "about:blank" like we do for about:home, about:addons, etc.)

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 478740 [details] [diff] [review]
patch

>         if (tab) {

>+          var overLink = tab.linkedBrowser.currentURI.spec;

nit: let

>+          if (overLink == "about:blank")
>+            overLink = null;
>+          XULBrowserWindow.setOverLink(overLink, null);

The first argument is supposed to be a string.

Comment 2

[Drew Willcoxon :adw]

Attachment: patch 2

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 479006 [details] [diff] [review]
patch 2

Requesting approval2.0, simple low-risk fix.

Comment 4

[Drew Willcoxon :adw]

http://hg.mozilla.org/mozilla-central/rev/ca1457ab42da